[U-Boot-Users] [PATCH] [DRIVERS] <asm/mpc8xxx_spi.h> is only available for ppc boards.

[Ben Warren <biggerbadderben@gmail.com>]

Andy Fleming wrote:
> On Jan 24, 2008 10:33 AM, Peter Pearse <peter.pearse@arm.com> wrote:
>   
>> +#if defined(CONFIG_MPC834X) || \
>> +       defined(CONFIG_MPC8313) || \
>> +       defined(CONFIG_MPC8315) || \
>> +       defined(CONFIG_MPC837X)
>>  #include <asm/mpc8xxx_spi.h>
>> +#endif
>>
>>  #ifdef CONFIG_HARD_SPI
>> ---
>>
>> or should asm-ppc/mpc8xxx_spi.h be moved to drivers/spi?
>>     
>
> Hm.  I'd prefer that, since that SPI driver will possibly propagate
> through *many* variants, and it seems silly to change the driver every
> time we make a new part.  :)
>
> I'm not familiar enough with the device or driver to know whether the
> header is truly ppc-specific, or just coincidentally so.
>
> Andy
>   
The header is specific to this SPI controller, but not really 
PPC-specific. I don't know enough about how Freescale works to know if 
the different divisions such as PPC and Coldfire and whatever else share 
building blocks like these controllers, but conceivably (in my mind at 
least) this could be on anything Freescale makes.

I'm no expert on Kconfig, but I think that once it's in play the 
Makefile for this driver determines whether to even compile the driver 
depending on whether a CONFIG is set or not. I probably forgot to define 
something like CONFIG_MPC8XXX_SPI. Maybe a change to the Makefile is 
needed here?

Sorry for the seemingly random mumblings.

regards,
Ben