From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Schwingen Date: Tue, 05 Feb 2008 10:45:56 +0100 Subject: [U-Boot-Users] [patch] do not use cmd_reset uninitialized in cfi_flash.c In-Reply-To: <200802041705.10934.sr@denx.de> References: <200801282227.06426.vapier@gentoo.org> <200802041113.49729.sr@denx.de> <47A733C9.3030207@discworld.dascon.de> <200802041705.10934.sr@denx.de> Message-ID: <47A83054.6020004@discworld.dascon.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Stefan Roese wrote: >> I think I can run tests on a small set (~5-10 different AMD-commandset >> and 2 intel-commandset, all 16 bit) flashs, but that still leaves the >> (small) possibility that there are flash roms that behave different. >> > > Right. But it will be an improvement to the current implementation, where a > random command is written as RESET command. And also an improvement to the > fixed AMD/Intel RESET command. So I vote for trying this solution. I'll test > on a few of mine platforms too. > > Michael, could please you provide a patch? > Yes, but it may take some days - I probably need to run the tests on a board that has socketed flash, using a special test case that really puts the flash in the middle of a command cycle and tests reset behaviour. cu Michael