From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH v4] QE IO: Add initial data to pin configuration + read/write functions
Date: Thu, 07 Feb 2008 09:57:37 -0600 [thread overview]
Message-ID: <47AB2A71.1030100@freescale.com> (raw)
In-Reply-To: <B27D27F93BC429468DBC3B0DA043AA4401D50923@ilptex01.ecitele.com>
David Saada wrote:
>> Don't use volatile. Use the accessor functions: in_be32 and out_be32.
> This was copied from the qe_config_iopin function, which still used the
> volatile directive. I can fix it there as well, but I see that it's used
> everywhere.
Yeah, and it's wrong everywhere, too.
> Maybe this needs a thorough change, but I'm not sure it
> should be in my humble patch.
Well, we may not have the time to fix all the wrong usages, but we shouldn't
make it worse. All new code should use the accessors.
>> Put these in a header file.
> Will change as well. I think ioports.h is good enough for this purpose.
> So far, qe_config_iopin wasn't there as well, so it will also be moved
> there.
I'm okay with that.
--
Timur Tabi
Linux kernel developer at Freescale
prev parent reply other threads:[~2008-02-07 15:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 14:31 [U-Boot-Users] [PATCH v2] QE IO: Add initial data to pin configuration + read/write functions David Saada
2008-01-17 17:30 ` Timur Tabi
2008-01-17 17:39 ` Timur Tabi
2008-01-20 6:48 ` David Saada
2008-01-20 9:36 ` [U-Boot-Users] [PATCH v3] " David Saada
2008-01-22 18:11 ` David Saada
2008-01-22 18:55 ` Timur Tabi
2008-01-23 7:47 ` David Saada
2008-01-23 22:43 ` Timur Tabi
2008-01-28 16:01 ` Timur Tabi
2008-01-28 16:21 ` David Saada
2008-02-05 16:54 ` Andy Fleming
2008-02-06 7:44 ` David Saada
2008-02-07 10:26 ` [U-Boot-Users] [PATCH v4] " David Saada
2008-02-07 15:28 ` Timur Tabi
2008-02-07 15:55 ` David Saada
2008-02-07 15:57 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47AB2A71.1030100@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox