[U-Boot-Users] [PATCH] Extend ATI Radeon driver to support more video modes

Rodolfo Giometti
2008-02-15T09:24:14Z

On Thu, Feb 14, 2008 at 01:39:14AM +0100, Wolfgang Denk wrote:
> In message <47B38277.6010001@denx.de> you wrote:
> >
> > >> +#if 1 /* @ 60 Hz */
> > >> + mode->crtc_h_total_disp = 0x009f00d2;
> > >> + mode->crtc_h_sync_strt_wid = 0x000e0528;
> > >> + mode->crtc_v_total_disp = 0x03ff0429;
> > >> + mode->crtc_v_sync_strt_wid = 0x00030400;
> > >> + mode->crtc_pitch = 0x00a000a0;
> > >> + mode->ppll_div_3 = 0x00010060;
> > >> +#else /* @ 75 Hz */
> > >> + mode->crtc_h_total_disp = 0x009f00d2;
> > >> + mode->crtc_h_sync_strt_wid = 0x00120508;
> > >> + mode->crtc_v_total_disp = 0x03ff0429;
> > >> + mode->crtc_v_sync_strt_wid = 0x00030400;
> > >> + mode->crtc_pitch = 0x00a000a0;
> > >> + mode->ppll_div_3 = 0x00010078;
> > >> +#endif
> > >
> > > Mmm... better adding a configuration define here or just remove the
> > > unused code.
> >
> > Ok, I'm going to drop the unused code then.
>
> No, please keep it as reference in case anybody needs this later.

Uh? =:-o Why did you change your mind? ;)

| Delivery-date: Sun, 01 Apr 2007 15:18:41 +0200
| From: Wolfgang Denk <wd@denx.de>
| To: Rodolfo Giometti <giometti@enneenne.com>
| cc: Markus Klotzb?cher <mk@denx.de>
| Subject: Re: [PATCH] ISP116x HCD (Host Controller Driver)
|
| [snip]
|
| Please remove code in "#if 0 ... #endif" blocks.
|
| [snip]
|
| Best regards,
|
| Wolfgang Denk

However I suggested also to add a configuration define, something
like:

#if defined(CFG_ATI_RADEON_60HZ)
...
#elif defined(CFG_ATI_RADEON_75HZ)
...
#else
#error "..."
#endif

This allow keeping the code in a better style... or we can rewrite it
as follow:

/* @ 60 Hz */
mode->crtc_h_total_disp = 0x009f00d2;
mode->crtc_h_sync_strt_wid = 0x000e0528;
mode->crtc_v_total_disp = 0x03ff0429;
mode->crtc_v_sync_strt_wid = 0x00030400;
mode->crtc_pitch = 0x00a000a0;
mode->ppll_div_3 = 0x00010060;

/* @ 75 Hz
*
* Still untested. Just use it as reference for future improvemets.
*
* mode->crtc_h_total_disp = 0x009f00d2;
* mode->crtc_h_sync_strt_wid = 0x00120508;
* mode->crtc_v_total_disp = 0x03ff0429;
* mode->crtc_v_sync_strt_wid = 0x00030400;
* mode->crtc_pitch = 0x00a000a0;
* mode->ppll_div_3 = 0x00010078;
*/

Ciao,

Rodolfo

--

GNU/Linux Solutions e-mail: giometti at enneenne.com
Linux Device Driver giometti at gnudd.com
Embedded Systems giometti at linux.it
UNIX programming phone: +39 349 2432127