public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Bartlomiej Sieka <tur@semihalf.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add 'imload' command
Date: Wed, 13 Feb 2008 21:22:52 +0100	[thread overview]
Message-ID: <47B3519C.2020909@semihalf.com> (raw)
In-Reply-To: <CD4480F8-B338-463E-8D42-5B4BC1A0C674@kernel.crashing.org>

Kumar Gala wrote:
[...]
>>>> - The load_image routine (and consequently imload commad) will not 
>>>> work when the image is stored in Data Flash.
>>> what's the issue here?
>>
>> Please have a look at code under CONFIG_HAS_DATAFLASH in get_kernel()
>> (formerly in do_bootm()), especially the read_dataflash() function. The
>> issue is that you have to copy data from Data Flash in a specific way in
>> order to have random access to it. So for example this line in your code:
>> type_name = image_get_type_name (image_get_type (hdr));
>> will effectively try to access hdr->ih_type, which will not work when
>> hdr is an address in Data Flash.
> 
> Just to be clear, at a quick glance, I assume load_image will work ok 
> from do_bootm() but not from do_imload().  (since do_bootm is calling 
> get_kernel).

Correct.

Regards,
Bartlomiej

  reply	other threads:[~2008-02-13 20:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13  5:10 [U-Boot-Users] [PATCH] Add 'imload' command Kumar Gala
2008-02-13 10:11 ` Bartlomiej Sieka
2008-02-13 13:06   ` Kumar Gala
2008-02-13 19:55     ` Bartlomiej Sieka
2008-02-13 20:15       ` Kumar Gala
2008-02-13 20:22         ` Bartlomiej Sieka [this message]
2008-02-13 20:34           ` Kumar Gala
2008-02-14  1:13       ` Grant Likely
2008-02-14  3:54         ` Kumar Gala
2008-02-14  7:38         ` Bartlomiej Sieka
2008-02-15 16:35         ` Detlev Zundel
2008-02-13 22:31 ` Wolfgang Denk
2008-02-13 22:38   ` Kumar Gala
2008-02-13 23:01     ` Wolfgang Denk
2008-02-13 23:46       ` Kumar Gala
2008-02-14  0:37         ` Wolfgang Denk
2008-02-14  0:50           ` Kumar Gala
2008-02-14  5:35   ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B3519C.2020909@semihalf.com \
    --to=tur@semihalf.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox