[U-Boot-Users] [PATCH] Fix building of fdt_support.c if DEBUG set

[U-Boot-Users] [PATCH] Fix building of fdt_support.c if DEBUG set

[Kumar Gala]

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---

Wolfgang, would like to see this go into mainline as it fixes building.

 common/fdt_support.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/fdt_support.c b/common/fdt_support.c
index 92f1c7f..69eb667 100644
--- a/common/fdt_support.c
+++ b/common/fdt_support.c
@@ -415,7 +415,7 @@ void do_fixup_by_path(void *fdt, const char *path, const char *prop,
 {
 #if defined(DEBUG)
 	int i;
-	debug("Updating property '%s/%s' = ", node, prop);
+	debug("Updating property '%s/%s' = ", path, prop);
 	for (i = 0; i < len; i++)
 		debug(" %.2x", *(u8*)(val+i));
 	debug("\n");
@@ -441,7 +441,7 @@ void do_fixup_by_prop(void *fdt,
 	int off;
 #if defined(DEBUG)
 	int i;
-	debug("Updating property '%s/%s' = ", node, prop);
+	debug("Updating property '%s' = ", prop);
 	for (i = 0; i < len; i++)
 		debug(" %.2x", *(u8*)(val+i));
 	debug("\n");
@@ -468,7 +468,7 @@ void do_fixup_by_compat(void *fdt, const char *compat,
 	int off = -1;
 #if defined(DEBUG)
 	int i;
-	debug("Updating property '%s/%s' = ", node, prop);
+	debug("Updating property '%s' = ", prop);
 	for (i = 0; i < len; i++)
 		debug(" %.2x", *(u8*)(val+i));
 	debug("\n");
-- 
1.5.3.8

[U-Boot-Users] [PATCH] Fix building of fdt_support.c if DEBUG set

[Jon Loeliger]

Kumar Gala wrote:
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---

Kumar, Thanks for getting this one!

Acked-by: Jon Loeliger <jdl@freescale.com>

[U-Boot-Users] [PATCH] Fix building of fdt_support.c if DEBUG set

[Jerry Van Baren]

Jon Loeliger wrote:
> Kumar Gala wrote:
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>> ---
> 
> Kumar, Thanks for getting this one!
> 
> Acked-by: Jon Loeliger <jdl@freescale.com>

Ditto.  That is on my list to check and add to u-boot-fdt, but if 
Wolfgang can apply this directly, it will heal the breakage faster.

My apologies for not catching it myself when I applied the original 
patch (obviously, I didn't do a build with DEBUG enabled).

I'm not wild about acking without personally building the patched s/w 
first, but it is pretty obviously broken so provisionally...

Acked-by: Gerald Van Baren <vanbaren@cideas.com>

gvb

[U-Boot-Users] [PATCH] Fix building of fdt_support.c if DEBUG set

[Wolfgang Denk]

In message <Pine.LNX.4.64.0802131508390.16606@blarg.am.freescale.net> you wrote:
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> 
> Wolfgang, would like to see this go into mainline as it fixes building.

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Objects in mirror are closer than they appear.