[U-Boot-Users] tftp warning/error?

[U-Boot-Users] tftp warning/error?

[Kumar Gala]

'TFTP: add host ip addr support' commit added this bit of code which  
seems bogus:

         } else {
                 char *p = strchr (p, ':');

Is this really correct?

- k

[U-Boot-Users] tftp warning/error?

[Jean-Christophe PLAGNIOL-VILLARD]

On 14:57 Wed 13 Feb     , Kumar Gala wrote:
> 'TFTP: add host ip addr support' commit added this bit of code which seems
> bogus:
>
>         } else {
>                 char *p = strchr (p, ':');
>
> Is this really correct?
No, it this
-		char *p = strchr (p, ':');
+		char *p = strchr (BootFile, ':');

Best Regards,
J.

[U-Boot-Users] [PATCH] TFTP: fix search of ':' in BootFile

[Jean-Christophe PLAGNIOL-VILLARD]

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

diff --git a/net/tftp.c b/net/tftp.c
index 3dd2b06..ea8fea2 100644
--- a/net/tftp.c
+++ b/net/tftp.c
@@ -474,7 +474,7 @@ TftpStart (void)
 		printf ("*** Warning: no boot file name; using '%s'\n",
 			tftp_filename);
 	} else {
-		char *p = strchr (p, ':');
+		char *p = strchr (BootFile, ':');
 
 		if (p == NULL) {
 			strncpy(tftp_filename, BootFile, MAX_LEN);
-- 
1.5.3.7

[U-Boot-Users] [PATCH] TFTP: fix search of ':' in BootFile

[Kumar Gala]

Wolfgang,

Can you pick this up as its a clear bug fix.

- k

On Feb 14, 2008, at 1:02 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:

> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD  
> <plagnioj@jcrosoft.com>
>
> diff --git a/net/tftp.c b/net/tftp.c
> index 3dd2b06..ea8fea2 100644
> --- a/net/tftp.c
> +++ b/net/tftp.c
> @@ -474,7 +474,7 @@ TftpStart (void)
> 		printf ("*** Warning: no boot file name; using '%s'\n",
> 			tftp_filename);
> 	} else {
> -		char *p = strchr (p, ':');
> +		char *p = strchr (BootFile, ':');
>
> 		if (p == NULL) {
> 			strncpy(tftp_filename, BootFile, MAX_LEN);
> -- 
> 1.5.3.7
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH] TFTP: fix search of ':' in BootFile

[Wolfgang Denk]

In message <1202972532-17372-1-git-send-email-plagnioj@jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> 
> diff --git a/net/tftp.c b/net/tftp.c
> index 3dd2b06..ea8fea2 100644
> --- a/net/tftp.c
> +++ b/net/tftp.c
> @@ -474,7 +474,7 @@ TftpStart (void)
>  		printf ("*** Warning: no boot file name; using '%s'\n",
>  			tftp_filename);
>  	} else {
> -		char *p = strchr (p, ':');
> +		char *p = strchr (BootFile, ':');

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Bureaucracy is the enemy of innovation."
       - Mark Shepherd, former President and CEO of Texas Instruments

[U-Boot-Users] [PATCH] TFTP: fix search of ':' in BootFile

[Wolfgang Denk]

In message <1202972532-17372-1-git-send-email-plagnioj@jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> 
> diff --git a/net/tftp.c b/net/tftp.c
> index 3dd2b06..ea8fea2 100644
> --- a/net/tftp.c
> +++ b/net/tftp.c
> @@ -474,7 +474,7 @@ TftpStart (void)
>  		printf ("*** Warning: no boot file name; using '%s'\n",
>  			tftp_filename);
>  	} else {
> -		char *p = strchr (p, ':');
> +		char *p = strchr (BootFile, ':');
>  
>  		if (p == NULL) {
>  			strncpy(tftp_filename, BootFile, MAX_LEN);

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If only God would give me some clear sign! Like making a large  depo-
sit in my name at a Swiss Bank.                         - Woody Allen

[U-Boot-Users] tftp warning/error?

[Ben Warren]

Kumar Gala wrote:
> 'TFTP: add host ip addr support' commit added this bit of code which  
> seems bogus:
>
>          } else {
>                  char *p = strchr (p, ':');
>
> Is this really correct?
>
> - k
>
>   
That's F-d up. The patches I have are like this:

- tftp_filename = BootFile;
+ char *p=BootFile;
+ p = strchr (p, ':');

but never got pulled into the net branch. I guess Wolfgang must have 
pulled directly. C'mon patch management system!!!

cheers,
Ben