public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Bug in dependency checking
Date: Mon, 18 Feb 2008 08:03:51 +0100	[thread overview]
Message-ID: <47B92DD7.5000506@denx.de> (raw)
In-Reply-To: <20080214220942.724592483C@gemini.denx.de>

Wolfgang Denk wrote:
> Hi,
> 
> there is a bug in the dependency checking. If we modify a source file,
> and then rebuild U-Boot, it will not generate a new git commit ID in
> the version string.
> 
> Can somebody please help me with this? Thanks in advance.

What about simply adding VERSION_FILE to the PHONY targets ? in this way 
the script /tools/setlocalversion is always called and 
version_autogenerated.h is replaced only if the script find a modified 
source file.

--- a/Makefile
+++ b/Makefile
@@ -244,7 +244,7 @@ LIBS += libfdt/libfdt.a
  LIBS += api/libapi.a

  LIBS := $(addprefix $(obj),$(LIBS))
-.PHONY : $(LIBS)
+.PHONY : $(LIBS) $(VERSION_FILE)

Regards,
stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2008-02-18  7:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-14 22:09 [U-Boot-Users] Bug in dependency checking Wolfgang Denk
2008-02-18  7:03 ` Stefano Babic [this message]
2008-02-22 11:16   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B92DD7.5000506@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox