[U-Boot-Users] [PATCH] 8610HPCD: Don't use VIDEO/CFB_CONSOLE by default.

[U-Boot-Users] [PATCH] 8610HPCD: Don't use VIDEO/CFB_CONSOLE by default.

[Jon Loeliger]

Without an actual supported video card hooked up, enabling
the CONFIG_VIDEO by default just makes it look broken by
routing all console output to the video card.   Don't.

Signed-off-by: Jon Loeliger <jdl@freescale.com>
---

Wolfgang,

I'll drop this in my -mpc86xx tree for a -rc2 pickup!

Thanks,
jdl


 include/configs/MPC8610HPCD.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/configs/MPC8610HPCD.h b/include/configs/MPC8610HPCD.h
index 3920147..9e70198 100644
--- a/include/configs/MPC8610HPCD.h
+++ b/include/configs/MPC8610HPCD.h
@@ -24,7 +24,7 @@
 #define CONFIG_FSL_DIU_FB	1	/* FSL DIU */
 
 /* video */
-#define CONFIG_VIDEO
+#undef CONFIG_VIDEO
 
 #if defined(CONFIG_VIDEO)
 #define CONFIG_CFB_CONSOLE
-- 
1.5.4.rc5.19.g0509eb

[U-Boot-Users] [PATCH] 8610HPCD: Don't use VIDEO/CFB_CONSOLE by default.

[Timur Tabi]

Jon Loeliger wrote:

> diff --git a/include/configs/MPC8610HPCD.h b/include/configs/MPC8610HPCD.h
> index 3920147..9e70198 100644
> --- a/include/configs/MPC8610HPCD.h
> +++ b/include/configs/MPC8610HPCD.h
> @@ -24,7 +24,7 @@
>  #define CONFIG_FSL_DIU_FB	1	/* FSL DIU */
>  
>  /* video */
> -#define CONFIG_VIDEO
> +#undef CONFIG_VIDEO
>  
>  #if defined(CONFIG_VIDEO)
>  #define CONFIG_CFB_CONSOLE

Wolfgang just applied a patch that removed unnecessary "#undef DEBUG", and your 
patch adds an unnecessary "#undef CONFIG_VIDEO".

-- 
Timur Tabi
Linux kernel developer at Freescale

[U-Boot-Users] [PATCH] 8610HPCD: Don't use VIDEO/CFB_CONSOLE by default.

[Jon Loeliger]

Timur Tabi wrote:

> Wolfgang just applied a patch that removed unnecessary "#undef DEBUG", 
> and your patch adds an unnecessary "#undef CONFIG_VIDEO".
> 

So?

jdl