From: Kim B. Heino <Kim.Heino@bluegiga.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] fix copy from ram to dataflash
Date: Mon, 03 Mar 2008 10:39:13 +0200 [thread overview]
Message-ID: <47CBB931.6070604@bluegiga.com> (raw)
In-Reply-To: <20080229111930.257FE24765@gemini.denx.de>
If I try to "cp.b <ram> <dataflash>", u-boot selects normal flash
routines instead of dataflash. This is because it checks "if source
address is not dataflash" instead of target address.
Signed-off-by: Kim B. Heino <Kim.Heino@bluegiga.com>
--- u-boot-1.3.2-rc3/common/cmd_mem.c.foo 2008-03-03 10:17:50.000000000 +0200
+++ u-boot-1.3.2-rc3/common/cmd_mem.c 2008-03-03 10:18:19.000000000 +0200
@@ -417,7 +417,7 @@ int do_mem_cp ( cmd_tbl_t *cmdtp, int fl
/* check if we are copying to Flash */
if ( (addr2info(dest) != NULL)
#ifdef CONFIG_HAS_DATAFLASH
- && (!addr_dataflash(addr))
+ && (!addr_dataflash(dest))
#endif
) {
int rc;
next prev parent reply other threads:[~2008-03-03 8:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 22:30 [U-Boot-Users] latest u-boot (1.3.2-rc2) and dataflash vs CFG_NO_FLASH Matt Gessner
2008-02-29 5:54 ` Kim B. Heino
2008-02-29 11:19 ` Wolfgang Denk
2008-03-03 8:39 ` Kim B. Heino [this message]
2008-03-03 20:48 ` [U-Boot-Users] [PATCH] fix copy from ram to dataflash Wolfgang Denk
2008-02-29 13:46 ` [U-Boot-Users] latest u-boot (1.3.2-rc2) and dataflash vs CFG_NO_FLASH Matt Gessner
2008-03-02 21:07 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CBB931.6070604@bluegiga.com \
--to=kim.heino@bluegiga.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox