From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerry Van Baren <gerald.vanbaren@ge.com>
Date: Fri, 07 Mar 2008 09:36:49 -0500
Subject: [U-Boot-Users] [PATCH] Add flash programming counter]
In-Reply-To: <20080307141357.3276E247B3@gemini.denx.de>
References: <20080307141357.3276E247B3@gemini.denx.de>
Message-ID: <47D15301.8060601@ge.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
> In message <47D149CA.8010205@ge.com> you wrote:
>> The saveenv also looks funky.  I only mucked with the cmd_mem.c command 
>> to make it display better with the progress dots, obviously the saveenv 
>> command needs to have the same changes
>>    s/"Writing to Flash... "/"Writing to Flash\n"/
> 
> Please don't.
> 
> That shall not become a 200 lines output. Please keep this on a single
> line.
> 
> It makes no sense to have all  useful  information  srolling  out  of
> sight all too quickly just for such bells and whistles.
> 
> Best regards,
> Wolfgang Denk

I was too terse.  The problem is that I added a progress bar. 
Previously, the printout sequence was:
   Writing to Flash...
followed by an indeterminate wait, followed by the string "done." which 
formed the composite:
   Writing to Flash... done.
I added a progress bar, but the progress bar needs to be on a new line. 
  I fixed this in cmd_mem.c, but not in the env code, resulting in 
Stefan's complaint (b).

With the (next version of the) progress dots patch, the sequence will be:
   Writing to Flash
                                                    v
   ..................................................
   done.

One thing I am debating is to add a parameter to the flash write command 
that says whether to do the progress dots or not.  Then we could 
suppress the (silly) dots on short writes.

Best regards,
gvb