public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add flash programming counter]
Date: Fri, 07 Mar 2008 11:09:18 -0500	[thread overview]
Message-ID: <47D168AE.7050006@ge.com> (raw)
In-Reply-To: <20080307145940.E9C1F247B3@gemini.denx.de>

Wolfgang Denk wrote:
> In message <47D15301.8060601@ge.com> you wrote:
>> I was too terse.  The problem is that I added a progress bar. 
>> Previously, the printout sequence was:
>>    Writing to Flash...
>> followed by an indeterminate wait, followed by the string "done." which 
>> formed the composite:
>>    Writing to Flash... done.
> 
> That's what it shall remain: a single line of text.
> 
>> I added a progress bar, but the progress bar needs to be on a new line. 
> 
> Please don't.
> 
> Best regards,
> Wolfgang Denk

There is no way to add an end marker without using a new line (or use 
'\r' which is really unacceptable, and more justifiably so).  Since we 
are settling in on having 50 (?probably want to use a #define) dots 
unless there are fewer than 50 units to be written, I suppose we can 
live without a end marker.  Sigh, the end marker was the fun part.

I also contend that it was a useful part even if you /know/ that there 
will be 50 dots because the human eye cannot count dots at a glance.

Illustration:

Tell me at a glance how close this is to completion[1]:
Writing to Flash..............................

Now tell me here:
Writing to Flash
                                                   v
..............................

With an added parameter to the flash write routine (which would serve 
double duty to suppress the progress dots), I can condense the above 
into two lines.  This is still 100% more lines than Wolfgang demands, 
but I think it has sufficient value to pay its freight.

Writing to Flash                                  v
..............................

Best regards,
gvb

[1] Answer: 60% done, 40% remaining for all the examples.

  reply	other threads:[~2008-03-07 16:09 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05 19:43 [U-Boot-Users] [PATCH] Add flash programming counter] York Sun
2008-03-06  6:20 ` Stefan Roese
2008-03-06  8:19   ` Martin Krause
2008-03-06 12:48   ` Wolfgang Denk
2008-03-06 13:33     ` Stefan Roese
2008-03-06 16:32       ` Wolfgang Denk
2008-03-06 17:17         ` Michael Schwingen
2008-03-06 19:35           ` Jerry Van Baren
2008-03-07 13:02             ` Clemens Koller
2008-03-07 13:11               ` Stefan Roese
2008-03-07 13:26                 ` Jerry Van Baren
2008-03-07 13:35                   ` Stefan Roese
2008-03-07 13:57                     ` Jerry Van Baren
2008-03-07 14:04                       ` Stefan Roese
2008-03-07 14:15                         ` Wolfgang Denk
2008-03-07 14:18                           ` Kumar Gala
2008-03-07 14:22                           ` Stefan Roese
2008-03-07 14:13                       ` Wolfgang Denk
2008-03-07 14:36                         ` Jerry Van Baren
2008-03-07 14:59                           ` Wolfgang Denk
2008-03-07 16:09                             ` Jerry Van Baren [this message]
2008-03-07 16:33                               ` Wolfgang Denk
2008-03-07 17:12                                 ` Jerry Van Baren
2008-03-07 19:36                                   ` Wolfgang Denk
2008-03-07 20:52                                     ` Jerry Van Baren
2008-03-07 17:46                                 ` Kim Phillips
2008-03-07 19:39                                   ` Wolfgang Denk
2008-03-07 14:10                 ` Wolfgang Denk
2008-03-07 13:24               ` Jerry Van Baren
2008-03-07 13:33                 ` Jerry Van Baren
2008-03-06 19:41           ` Stefan Roese
2008-03-06 22:58             ` Wolfgang Denk
2008-03-07  6:38               ` Stefan Roese
2008-03-07 16:34                 ` Jon Loeliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47D168AE.7050006@ge.com \
    --to=gerald.vanbaren@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox