public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] mpc83xx: make dtb basename file references equal those of linux
Date: Fri, 07 Mar 2008 15:47:34 -0500	[thread overview]
Message-ID: <47D1A9E6.80601@ge.com> (raw)
In-Reply-To: <20080307142832.7d317b31.kim.phillips@freescale.com>

Kim Phillips wrote:
> On Fri, 07 Mar 2008 20:38:31 +0100
> Wolfgang Denk <wd@denx.de> wrote:
> 
>> In message <20080307122731.1ecaf291.kim.phillips@freescale.com> you wrote:
>>> the dts file basenames were updated in linux - this helps avoid
>>> inadvertently loading any old dtbs laying around.
>>>
>>> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
>>> ---
>>>  include/configs/MPC832XEMDS.h |    2 +-
>>>  include/configs/MPC8360EMDS.h |    2 +-
>>>  include/configs/MPC837XEMDS.h |    2 +-
>>>  include/configs/MPC837XERDB.h |    2 +-
>>>  4 files changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/include/configs/MPC832XEMDS.h b/include/configs/MPC832XEMDS.h
>>> index 702b073..f32c4f7 100644
>>> --- a/include/configs/MPC832XEMDS.h
>>> +++ b/include/configs/MPC832XEMDS.h
>>> @@ -583,7 +583,7 @@
>>>     "ramdiskaddr=1000000\0"						\
>>>     "ramdiskfile=ramfs.83xx\0"						\
>>>     "fdtaddr=400000\0"							\
>>> -   "fdtfile=mpc832xemds.dtb\0"						\
>>> +   "fdtfile=mpc832x_mds.dtb\0"						\
>> I don't think this is a good idea. File names and board config  names
>> should  match  as  far  as  possible,  and  here is no good reason to
>> deviate from this rule.
>>
>> I tend to NAK this.
> 
> but these are the filenames in linux' device tree directory -
> arch/powerpc/boot/dts, and I'm assuming people do something sane like
> dtc -I $file.dts -O $file.dtb.
> 
> are you suggesting we rename u-boot's config files too?
> 
> Kim

I'm with Kim & Timur on this one.  The kernel is in the driver's seat on 
the .dts, and thus the .dtb file names for these targets.

Best regards,
gvb

  reply	other threads:[~2008-03-07 20:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-07 18:27 [U-Boot-Users] [PATCH] mpc83xx: make dtb basename file references equal those of linux Kim Phillips
2008-03-07 19:38 ` Wolfgang Denk
2008-03-07 20:27   ` Timur Tabi
2008-03-08  0:59     ` Wolfgang Denk
2008-03-10 15:03       ` Timur Tabi
2008-03-07 20:28   ` Kim Phillips
2008-03-07 20:47     ` Jerry Van Baren [this message]
2008-03-08  1:04       ` Wolfgang Denk
2008-03-08  1:03     ` Wolfgang Denk
2008-03-08  2:48       ` Kim Phillips
2008-03-08  9:19         ` Wolfgang Denk
2008-03-10 13:59           ` Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47D1A9E6.80601@ge.com \
    --to=gerald.vanbaren@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox