From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Loeliger Date: Wed, 12 Mar 2008 12:02:40 -0500 Subject: [U-Boot-Users] [RFC/PATCH] fix initdram / use of phys_addr_t In-Reply-To: References: Message-ID: <47D80CB0.30100@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Kumar Gala wrote: > Wolfgang, > > Before I went and looked at every board that uses initdram I wanted to get > some feedback of such a patch (for a wide majority of boards) would be > acceptable. > > The idea is that initdram() should really have returned a 'unsigned long'. > However if we are going to change everyone that has initdram I figure we > should make it return a phys_addr_t. > > I believe you've had some discussions with Jon on the subject and I wanted > to know if using 'phys_addr_t' here would be acceptable (before I looked > at trying to fix up ~200 boards). > > The patch gives an example of what I'm looking at changing. > > - k Just FYI, I am in full support of this proposed change to use phys_addr_t. > index cd8aad0..229d15a 100644 > --- a/include/common.h > +++ b/include/common.h > @@ -107,6 +107,8 @@ typedef volatile unsigned char vu_char; > #include > #endif > > +#include > + I don't think asm/io.h is the right place for phys_addr_t. However, adding it to asm/types.h might me. That is where Becky and I have been headed... jdl