[U-Boot-Users] [PATCH] mpc5200 without fec

[U-Boot-Users] [PATCH] mpc5200 without fec

[André Schwarz]

include fec specific nodes in ft_cpu_setup only if CONFIG_MPC5xxx_FEC is 
  defined. Systems without FEC, i.e. no fec node in dtb, should be possible.

Signed-off-by: Andre Schwarz <andre.schwarz@matrix-vision.de>
---


MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler  - Registergericht: Amtsgericht Stuttgart, HRB 271090
Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diff_fec
Url: http://lists.denx.de/pipermail/u-boot/attachments/20080313/c2b3e8cd/attachment.txt 

[U-Boot-Users] [PATCH] mpc5200 without fec

[Grant Likely]

On Thu, Mar 13, 2008 at 6:50 AM, Andr? Schwarz
<andre.schwarz@matrix-vision.de> wrote:
> include fec specific nodes in ft_cpu_setup only if CONFIG_MPC5xxx_FEC is
>   defined. Systems without FEC, i.e. no fec node in dtb, should be possible.
>
>  Signed-off-by: Andre Schwarz <andre.schwarz@matrix-vision.de>

Hmm; if there is no fec node; then won't this just fail silently?  In
which case; I'd rather avoid adding more inline #ifdefs to the code.
(correct me if I'm wrong)

Cheers,
g.

>  ---
>
>
>  MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler  - Registergericht: Amtsgericht Stuttgart, HRB 271090
>  Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
>
> diff --git a/cpu/mpc5xxx/cpu.c b/cpu/mpc5xxx/cpu.c
>  index e4d6168..dbfdd97 100644
>  --- a/cpu/mpc5xxx/cpu.c
>  +++ b/cpu/mpc5xxx/cpu.c
>  @@ -119,7 +119,9 @@ void ft_cpu_setup(void *blob, bd_t *bd)
>   {
>         int div = in_8((void*)CFG_MBAR + 0x204) & 0x0020 ? 8 : 4;
>         char * cpu_path = "/cpus/" OF_CPU;
>  +#ifdef CONFIG_MPC5xxx_FEC
>         char * eth_path = "/" OF_SOC "/ethernet at 3000";
>  +#endif
>
>         do_fixup_by_path_u32(blob, cpu_path, "timebase-frequency", OF_TBCLK, 1);
>         do_fixup_by_path_u32(blob, cpu_path, "bus-frequency", bd->bi_busfreq, 1);
>  @@ -127,7 +129,9 @@ void ft_cpu_setup(void *blob, bd_t *bd)
>         do_fixup_by_path_u32(blob, "/" OF_SOC, "bus-frequency", bd->bi_ipbfreq, 1);
>         do_fixup_by_path_u32(blob, "/" OF_SOC, "system-frequency",
>                                 bd->bi_busfreq*div, 1);
>  +#ifdef CONFIG_MPC5xxx_FEC
>         do_fixup_by_path(blob, eth_path, "mac-address", bd->bi_enetaddr, 6, 0);
>         do_fixup_by_path(blob, eth_path, "local-mac-address", bd->bi_enetaddr, 6, 0);
>  +#endif
>   }
>   #endif
>
> -------------------------------------------------------------------------
>  This SF.net email is sponsored by: Microsoft
>  Defy all challenges. Microsoft(R) Visual Studio 2008.
>  http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
>  U-Boot-Users mailing list
>  U-Boot-Users at lists.sourceforge.net
>  https://lists.sourceforge.net/lists/listinfo/u-boot-users
>
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

[U-Boot-Users] [PATCH] mpc5200 without fec

[Andre Schwarz]

Grant Likely schrieb:
> On Thu, Mar 13, 2008 at 6:50 AM, Andr? Schwarz
> <andre.schwarz@matrix-vision.de> wrote:
>   
>> include fec specific nodes in ft_cpu_setup only if CONFIG_MPC5xxx_FEC is
>>   defined. Systems without FEC, i.e. no fec node in dtb, should be possible.
>>
>>  Signed-off-by: Andre Schwarz <andre.schwarz@matrix-vision.de>
>>     
>
> Hmm; if there is no fec node; then won't this just fail silently?  In
> which case; I'd rather avoid adding more inline #ifdefs to the code.
> (correct me if I'm wrong)
>
> Cheers,
> g.
>
>   
it fails - but not silently. If you don't care for the error messages on 
the console you don't need it.
I don't like _any_ error message :-)

After all it's not a board specific #ifdef ...

>>  ---
>>
>>
>>  MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler  - Registergericht: Amtsgericht Stuttgart, HRB 271090
>>  Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
>>
>> diff --git a/cpu/mpc5xxx/cpu.c b/cpu/mpc5xxx/cpu.c
>>  index e4d6168..dbfdd97 100644
>>  --- a/cpu/mpc5xxx/cpu.c
>>  +++ b/cpu/mpc5xxx/cpu.c
>>  @@ -119,7 +119,9 @@ void ft_cpu_setup(void *blob, bd_t *bd)
>>   {
>>         int div = in_8((void*)CFG_MBAR + 0x204) & 0x0020 ? 8 : 4;
>>         char * cpu_path = "/cpus/" OF_CPU;
>>  +#ifdef CONFIG_MPC5xxx_FEC
>>         char * eth_path = "/" OF_SOC "/ethernet at 3000";
>>  +#endif
>>
>>         do_fixup_by_path_u32(blob, cpu_path, "timebase-frequency", OF_TBCLK, 1);
>>         do_fixup_by_path_u32(blob, cpu_path, "bus-frequency", bd->bi_busfreq, 1);
>>  @@ -127,7 +129,9 @@ void ft_cpu_setup(void *blob, bd_t *bd)
>>         do_fixup_by_path_u32(blob, "/" OF_SOC, "bus-frequency", bd->bi_ipbfreq, 1);
>>         do_fixup_by_path_u32(blob, "/" OF_SOC, "system-frequency",
>>                                 bd->bi_busfreq*div, 1);
>>  +#ifdef CONFIG_MPC5xxx_FEC
>>         do_fixup_by_path(blob, eth_path, "mac-address", bd->bi_enetaddr, 6, 0);
>>         do_fixup_by_path(blob, eth_path, "local-mac-address", bd->bi_enetaddr, 6, 0);
>>  +#endif
>>   }
>>   #endif
>>
>> -------------------------------------------------------------------------
>>  This SF.net email is sponsored by: Microsoft
>>  Defy all challenges. Microsoft(R) Visual Studio 2008.
>>  http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>> _______________________________________________
>>  U-Boot-Users mailing list
>>  U-Boot-Users at lists.sourceforge.net
>>  https://lists.sourceforge.net/lists/listinfo/u-boot-users
>>
>>
>>     
>
>
>
>   



MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler  - Registergericht: Amtsgericht Stuttgart, HRB 271090
Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20080313/c2ec8934/attachment.htm 

[U-Boot-Users] [PATCH] mpc5200 without fec

[Grant Likely]

On Thu, Mar 13, 2008 at 11:05 AM, Andre Schwarz
<andre.schwarz@matrix-vision.de> wrote:
>
>  it fails - but not silently. If you don't care for the error messages on
> the console you don't need it.
>  I don't like _any_ error message :-)
>
>  After all it's not a board specific #ifdef ...

Okay then.

Acked-by: Grant Likely <grant.likely@secretlab.ca>

Wolfgang, can you please pick this one up?

Thanks,
g.


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

[U-Boot-Users] [PATCH] mpc5200 without fec

[Wolfgang Denk]

In message <47D9232C.5020208@matrix-vision.de> you wrote:
> This is a multi-part message in MIME format.
> --------------090008080204070507060201
> Content-Type: text/plain; charset=ISO-8859-15; format=flowed
> Content-Transfer-Encoding: 7bit
> 
> include fec specific nodes in ft_cpu_setup only if CONFIG_MPC5xxx_FEC is 
>   defined. Systems without FEC, i.e. no fec node in dtb, should be possible.
> 
> Signed-off-by: Andre Schwarz <andre.schwarz@matrix-vision.de>

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Things are not as simple as they seem at first.        - Edward Thorp

[U-Boot-Users] [PATCH] mpc5200 without fec

[Wolfgang Denk]

In message <fa686aa40803131103r4a1c3fa7qec63655b20fdc014@mail.gmail.com> you wrote:
> 
> Okay then.
> 
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> 
> Wolfgang, can you please pick this one up?

Sure - done.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every time history repeats itself the price goes up.