public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dave Littell <littelld@verizon.net>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Possible memory leak in cpu/ppc4xx/4xx_enet.c
Date: Fri, 14 Mar 2008 21:44:13 -0500	[thread overview]
Message-ID: <47DB37FD.9000705@verizon.net> (raw)

Hi all,

I've seen an issue with my 1.3.1-based port of U-Boot where a relatively
large number of pings issued from the command line will ultimately fail
with the message:

Cannot allocate private hw data for eth_device...

I looked around this message and it seems that ppc_4xx_eth_initialize()
malloc()?s a EMAC_4XX_HW_PST structure and assigns it to dev->priv.
However, nothing ever frees this buffer so standing on a ping will
ultimately pull down all the available memory.

One fix might be to free( dev->priv ) at the end of ppc_4xx_eth_halt().
 I tried this today and noted no ill effects.


Thanks,
Dave

             reply	other threads:[~2008-03-15  2:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-15  2:44 Dave Littell [this message]
2008-03-15  6:07 ` [U-Boot-Users] Possible memory leak in cpu/ppc4xx/4xx_enet.c Stefan Roese
2008-03-15 15:12   ` Dave Littell
2008-03-17  8:56     ` Stefan Roese
2008-03-17 23:10       ` Dave Littell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47DB37FD.9000705@verizon.net \
    --to=littelld@verizon.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox