From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add support for setting the I2C bus speed in fsl_i2c.c
Date: Sat, 15 Mar 2008 16:27:30 -0500 [thread overview]
Message-ID: <47DC3F42.7060707@freescale.com> (raw)
In-Reply-To: <20080315073556.GA11877@game.jcrosoft.org>
Jean-Christophe PLAGNIOL-VILLARD wrote:
>> This patch is for U-Boot 1.3.3. It affects 83xx, 85xx, and 86xx.
>>
>> #endif /* CONFIG_HARD_I2C */
>> #endif /* CONFIG_FSL_I2C */
> Could you btw move this to the Makefile
If I did, then I'd be doing two completely different things in one patch. I
understand the need to update the code to the new config model, but sliming
that change into other patches is probably not acceptable.
What does everyone think?
--
Timur Tabi
Linux Kernel Developer @ Freescale
next prev parent reply other threads:[~2008-03-15 21:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 22:45 [U-Boot-Users] [PATCH] Add support for setting the I2C bus speed in fsl_i2c.c Timur Tabi
2008-03-15 7:35 ` Jean-Christophe PLAGNIOL-VILLARD
2008-03-15 21:27 ` Timur Tabi [this message]
2008-03-26 15:39 ` Timur Tabi
2008-03-26 16:36 ` Andy Fleming
2008-03-26 23:12 ` Wolfgang Denk
2008-03-27 14:33 ` Timur Tabi
2008-03-27 9:11 ` Luigi 'Comio' Mantellini
2008-03-27 9:45 ` Luigi 'Comio' Mantellini
2008-03-27 14:46 ` Timur Tabi
2008-03-27 14:56 ` Wolfgang Denk
2008-03-27 17:30 ` Liew Tsi Chung
2008-03-27 17:50 ` Timur Tabi
2008-03-27 18:42 ` Liew Tsi Chung
2008-04-14 1:09 ` Wolfgang Denk
2008-04-14 1:09 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47DC3F42.7060707@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox