From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shinya Kuribayashi Date: Tue, 18 Mar 2008 09:40:49 +0900 Subject: [U-Boot-Users] [MIPS] cpu/mips/cache.S: Introduce NESTED(), LEAF() and END() In-Reply-To: <20080317211228.A4171246C5@gemini.denx.de> References: <20080317211228.A4171246C5@gemini.denx.de> Message-ID: <47DF0F91.3020805@ruby.dti.ne.jp> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > In message <47DE8444.3060603@ruby.dti.ne.jp> you wrote: >> These macros have been widely used by MIPS assemblers, and of course >> make codes more readable and easily maintainable. > > I have to admit that for me the resulting code is NOT better > readable. Indead of just reading a single source file, I now have to > look up a header file for a number of macros. You need to look up a header file, true. But these macros are worth doing so. > Speaking for myself, I don't see an improvement. as can be seen from macro definitions, they specify some more information ecplicitly; alignment, type of symbols, stack frame info which helps generating debug info. These macros or their variants have been used in SGI or Algorithmics early MIPS programming, PMON, YAMON and of course Linux. They are good helper for MIPS assemblers, so I hope get them in. Shinya