From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Wed, 19 Mar 2008 08:25:55 -0400 Subject: [U-Boot-Users] [PATCH] CFI: Small cleanup for FLASH_SHOW_PROGRESS In-Reply-To: <1205907215-20486-1-git-send-email-sr@denx.de> References: <1205907215-20486-1-git-send-email-sr@denx.de> Message-ID: <47E10653.1010307@ge.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Stefan Roese wrote: > With this patch we don't need that many #ifdef's in the code. It moves > the subtraction into the macro and defines a NOP-macro when > CONFIG_FLASH_SHOW_PROGRESS is not defined. > > Signed-off-by: Stefan Roese > --- > > Jerry, what do you think? If you are ok with to this one, and > nobody else has some objections, I'll submit both patches. > > drivers/mtd/cfi_flash.c | 22 +++++++++------------- > 1 files changed, 9 insertions(+), 13 deletions(-) Yes, there was that little birdie in the back of my mind saying this could be cleaner when I moved the code into the macro and didn't move the increment in too (because the increment was different amounts). Thanks for chirping louder. :-) Acked-by: Gerald Van Baren