public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] ColdFire: Fix FEC transmit issue for MCF5275
Date: Wed, 19 Mar 2008 09:05:27 -0500	[thread overview]
Message-ID: <47E11DA7.6000404@freescale.com> (raw)
In-Reply-To: <1205879362-3949-1-git-send-email-Tsi-Chung.Liew@freescale.com>

Tsi-Chung Liew wrote:

> +	/*
> +	 * FEC fix for MCF5275, FEC unable to initial transmit data packet.
> +	 * A nop will ensure the descriptor polling active completed.
> +	 */
> +#ifdef CONFIG_M5275
> +	__asm__ ("nop");
> +#endif
> +
>  #ifdef CFG_UNIFY_CACHE
>  	icache_invalid();
>  #endif

At the risk of being very picky, I think this should be
written to have the comment inside the #ifdef so that
the code and comment are not accidentally separated.

#if defined(CONFIG_M5275)
	/*
	 * FEC ...
	 */
	__asm__("nop");
#endif

But, that may be just me.  Take it or leave it. :-)

jdl

  reply	other threads:[~2008-03-19 14:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-18 22:29 [U-Boot-Users] [PATCH] ColdFire: Fix FEC transmit issue for MCF5275 Tsi-Chung Liew
2008-03-19 14:05 ` Jon Loeliger [this message]
2008-03-19 15:18   ` Scott Wood
  -- strict thread matches above, loose matches on Subject: below --
2008-03-20  0:55 Tsi-Chung Liew
2008-03-17 22:08 Tsi-Chung Liew
2008-03-18 21:29 ` Wolfgang Denk
2008-03-30  4:18 ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E11DA7.6000404@freescale.com \
    --to=jdl@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox