From: Jon Loeliger <jdl@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/2] mpc83xx: Add MPC837x PCIE controller RC mode
Date: Tue, 25 Mar 2008 09:29:04 -0500 [thread overview]
Message-ID: <47E90C30.9050701@freescale.com> (raw)
In-Reply-To: <87abkndpo0.fsf_-_@denx.de>
Markus Klotzb?cher wrote:
> Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> writes:
>
>>> +
>>> + reg16 = in_le16(hose_cfg_base + PEX_LTSSM_STAT);
>>> + if (reg16 < 0x16) {
>>> + printf("No link\n");
>>> + hose->indirect_type = INDIRECT_TYPE_NO_PCIE_LINK;
>>> + } else {
>>> + printf("link\n");
>>> + }
>> please remove the bracket on the else
>
> Come on, this is being ridiculously pedantic.
Absolutely agree.
In my opinion, extra braces should just acceptable
and even encouraged.
jdl
prev parent reply other threads:[~2008-03-25 14:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 18:42 [U-Boot-Users] [PATCH 1/2] mpc83xx: Add MPC837x PCIE controller RC mode Anton Vorontsov
2008-03-25 10:04 ` Liu Dave
2008-03-25 10:36 ` Jean-Christophe PLAGNIOL-VILLARD
2008-03-25 11:11 ` Markus Klotzbücher
2008-03-25 14:29 ` Jon Loeliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E90C30.9050701@freescale.com \
--to=jdl@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox