From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Loeliger Date: Tue, 25 Mar 2008 09:29:04 -0500 Subject: [U-Boot-Users] [PATCH 1/2] mpc83xx: Add MPC837x PCIE controller RC mode In-Reply-To: <87abkndpo0.fsf_-_@denx.de> References: <20080324184211.GA13282@localhost.localdomain> <20080325103613.GA32107@game.jcrosoft.org> <87abkndpo0.fsf_-_@denx.de> Message-ID: <47E90C30.9050701@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Markus Klotzb?cher wrote: > Jean-Christophe PLAGNIOL-VILLARD writes: > >>> + >>> + reg16 = in_le16(hose_cfg_base + PEX_LTSSM_STAT); >>> + if (reg16 < 0x16) { >>> + printf("No link\n"); >>> + hose->indirect_type = INDIRECT_TYPE_NO_PCIE_LINK; >>> + } else { >>> + printf("link\n"); >>> + } >> please remove the bracket on the else > > Come on, this is being ridiculously pedantic. Absolutely agree. In my opinion, extra braces should just acceptable and even encouraged. jdl