public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Larry Johnson <lrj@acm.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH v4] ppc: Add CFG_MEM_TOP_HIDE option to hide	memory area that doesn't get "touched"
Date: Wed, 26 Mar 2008 21:23:39 -0500	[thread overview]
Message-ID: <47EB052B.8060408@acm.org> (raw)
In-Reply-To: <1206523009-18011-1-git-send-email-sr@denx.de>

Stefan Roese wrote:
>[...]
> +- CFG_MEM_TOP_HIDE (PPC only):
> +		If CFG_MEM_TOP_HIDE is defined in the board config header,
> +		this specified memory area will get subtracted from the top
> +		(end) of ram and won't get "touched" at all by U-Boot. By
> +		fixing up gd->ram_size the Linux kernel should gets passed
> +		the now "corrected" memory size and won't touch it either.
> +		This should work for arch/ppc and arch/powerpc. Only Linux
> +		board ports in arch/powerpc with bootwrapper support, that
> +		recalculate the memory size from the SDRAM controller setup
> +		will have to get fixed.
>[...]

Hi Stefan,

I also have a nit to pick :-) .  It's not clear to me whether the clause
in the last sentence is meant to be restrictive or non-restrictive.  If
restrictive, I recommend removing the comma before the word "that".  If
non-restrictive, I recommend replacing the word "that" with the word
"which".

Best regards,
Larry

  parent reply	other threads:[~2008-03-27  2:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-26  9:16 [U-Boot-Users] [PATCH v4] ppc: Add CFG_MEM_TOP_HIDE option to hide memory area that doesn't get "touched" Stefan Roese
2008-03-26 22:33 ` Wolfgang Denk
2008-03-27  6:12   ` Stefan Roese
2008-03-27  2:23 ` Larry Johnson [this message]
2008-03-27  2:28   ` Larry Johnson
2008-03-27  5:55   ` Stefan Roese
2008-03-27 18:34     ` Larry Johnson
2008-03-27 18:40       ` Jerry Van Baren
2008-03-27 22:05         ` Wolfgang Denk
2008-03-28 10:05       ` Stefan Roese
2008-03-28 14:54         ` Larry Johnson
2008-03-28 16:13 ` Kumar Gala
2008-03-28 16:40   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47EB052B.8060408@acm.org \
    --to=lrj@acm.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox