From mboxrd@z Thu Jan 1 00:00:00 1970 From: Larry Johnson Date: Wed, 26 Mar 2008 21:23:39 -0500 Subject: [U-Boot-Users] [PATCH v4] ppc: Add CFG_MEM_TOP_HIDE option to hide memory area that doesn't get "touched" In-Reply-To: <1206523009-18011-1-git-send-email-sr@denx.de> References: <1206523009-18011-1-git-send-email-sr@denx.de> Message-ID: <47EB052B.8060408@acm.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Stefan Roese wrote: >[...] > +- CFG_MEM_TOP_HIDE (PPC only): > + If CFG_MEM_TOP_HIDE is defined in the board config header, > + this specified memory area will get subtracted from the top > + (end) of ram and won't get "touched" at all by U-Boot. By > + fixing up gd->ram_size the Linux kernel should gets passed > + the now "corrected" memory size and won't touch it either. > + This should work for arch/ppc and arch/powerpc. Only Linux > + board ports in arch/powerpc with bootwrapper support, that > + recalculate the memory size from the SDRAM controller setup > + will have to get fixed. >[...] Hi Stefan, I also have a nit to pick :-) . It's not clear to me whether the clause in the last sentence is meant to be restrictive or non-restrictive. If restrictive, I recommend removing the comma before the word "that". If non-restrictive, I recommend replacing the word "that" with the word "which". Best regards, Larry