[U-Boot-Users] [PATCH v4] ppc: Add CFG_MEM_TOP_HIDE option to hide memory area that doesn't get "touched"

[Larry Johnson <lrj@acm.org>]

I wrote:
> Stefan Roese wrote:
>> [...]
>> +- CFG_MEM_TOP_HIDE (PPC only):
>> +        If CFG_MEM_TOP_HIDE is defined in the board config header,
>> +        this specified memory area will get subtracted from the top
>> +        (end) of ram and won't get "touched" at all by U-Boot. By
>> +        fixing up gd->ram_size the Linux kernel should gets passed
>> +        the now "corrected" memory size and won't touch it either.
>> +        This should work for arch/ppc and arch/powerpc. Only Linux
>> +        board ports in arch/powerpc with bootwrapper support, that
>> +        recalculate the memory size from the SDRAM controller setup
>> +        will have to get fixed.
>> [...]
> 
> Hi Stefan,
> 
> I also have a nit to pick :-) .  It's not clear to me whether the clause
> in the last sentence is meant to be restrictive or non-restrictive.  If
> restrictive, I recommend removing the comma before the word "that".  If
> non-restrictive, I recommend replacing the word "that" with the word
> "which".

Oops, I forgot to write that, for the non-restrictive clause, there
should also be a comma after the word "setup".

Best regards,
Larry