From mboxrd@z Thu Jan  1 00:00:00 1970
From: Timur Tabi <timur@freescale.com>
Date: Thu, 27 Mar 2008 09:46:23 -0500
Subject: [U-Boot-Users] [PATCH] Add support for setting the
 I2C	bus	speed in fsl_i2c.c
In-Reply-To: <1206611122.23794.13.camel@localhost>
References: <1205534729-26151-1-git-send-email-timur@freescale.com>	
	<1206609090.23794.11.camel@localhost>
	<1206611122.23794.13.camel@localhost>
Message-ID: <47EBB33F.9000308@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Luigi 'Comio' Mantellini wrote:
> This patch should resolve the compilation issues on 547x/548x cpus.

Sorry, I didn't even think to check for anything outside of PowerPC.  I had no
idea m68k used fsl_i2c.c.

> @@ -47,6 +47,9 @@ typedef	struct	global_data {
>  	unsigned long	vco_clk;
>  	unsigned long	flb_clk;
>  #endif
> +#ifdef CONFIG_MCF547x_8x
> +	u32 i2c1_clk;
> +#endif
>  	unsigned long	ram_size;	/* RAM size */
>  	unsigned long	reloc_off;	/* Relocation Offset */
>  	unsigned long	reset_status;	/* reset status register at boot	*/

I suggest that you get rid of the #ifdef and always define i2c1_clk.  The value
will be set to 0 on systems that don't have an I2C.  I'm planning on submitting
patches to asm-ppc/global_data.h to get rid of a bunch of #ifdefs because it's
getting too messy.

Either way, I ACK this patch.

-- 
Timur Tabi
Linux kernel developer at Freescale