public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Larry Johnson <lrj@acm.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH v4] ppc: Add CFG_MEM_TOP_HIDE option to hide memory area that doesn't get "touched"
Date: Fri, 28 Mar 2008 09:54:56 -0500	[thread overview]
Message-ID: <47ED06C0.7000306@acm.org> (raw)
In-Reply-To: <200803281105.33719.sr@denx.de>

Stefan Roese wrote:
> On Thursday 27 March 2008, Larry Johnson wrote:
>> It's clear now, but unfortunately I don't know enough to tell whether it
>> is also correct :-( .  The statement as now written implies that the
>> statement without the clause, i.e., "Only Linux board ports in
>> arch/powerpc with bootwrapper support will have to get fixed in Linux
>> additionally", is also true.  If this is not correct (because boards
>> that do not recalculate their memory size do not need to be fixed in
>> Linux), then you would write: "Only Linux board ports in arch/powerpc
>> with bootwrapper support that recalculate the memory size from the SDRAM
>> controller setup will have to get fixed in Linux additionally."
> 
> Now I'm confused. :) 
> 
> Here is the current version I now have in my "master" branch (with your last 
> sentense):
> 
> - CFG_MEM_TOP_HIDE (PPC only):
> 		If CFG_MEM_TOP_HIDE is defined in the board config header,
> 		this specified memory area will get subtracted from the top
> 		(end) of ram and won't get "touched" at all by U-Boot. By
> 		fixing up gd->ram_size the Linux kernel should gets passed
> 		the now "corrected" memory size and won't touch it either.
> 		This should work for arch/ppc and arch/powerpc. Only Linux
> 		board ports in arch/powerpc with bootwrapper support that
> 		recalculate the memory size from the SDRAM controller setup
> 		will have to get fixed in Linux additionally.
> 
> 		This option can be used as a workaround for the 440EPx/GRx
> 		CHIP 11 errata where the last 256 bytes in SDRAM shouldn't
> 		be touched.
> 
> 		WARNING: Please make sure that this value is a multiple of
> 		the Linux page size (normally 4k). If this is not the case,
> 		then the end address of the Linux memory will be located at a
> 		non page size aligned address and this could cause major
> 		problems.
> 
> Please send a patch to change this description if necessary.
> 
> Thanks.

I'm not explaining it well, you can look at
"http://en.wikipedia.org/wiki/English_relative_clauses" for a better
explanation.  What you have above should be technically correct, at
worse it would be redundant.

Best regards,
Larry

  reply	other threads:[~2008-03-28 14:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-26  9:16 [U-Boot-Users] [PATCH v4] ppc: Add CFG_MEM_TOP_HIDE option to hide memory area that doesn't get "touched" Stefan Roese
2008-03-26 22:33 ` Wolfgang Denk
2008-03-27  6:12   ` Stefan Roese
2008-03-27  2:23 ` Larry Johnson
2008-03-27  2:28   ` Larry Johnson
2008-03-27  5:55   ` Stefan Roese
2008-03-27 18:34     ` Larry Johnson
2008-03-27 18:40       ` Jerry Van Baren
2008-03-27 22:05         ` Wolfgang Denk
2008-03-28 10:05       ` Stefan Roese
2008-03-28 14:54         ` Larry Johnson [this message]
2008-03-28 16:13 ` Kumar Gala
2008-03-28 16:40   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47ED06C0.7000306@acm.org \
    --to=lrj@acm.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox