From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Sun, 30 Mar 2008 00:18:15 -0400 Subject: [U-Boot-Users] [PATCH] ColdFire: Fix FEC transmit issue for MCF5275 In-Reply-To: <1205791696-17263-1-git-send-email-Tsi-Chung.Liew@freescale.com> References: <1205791696-17263-1-git-send-email-Tsi-Chung.Liew@freescale.com> Message-ID: <47EF1487.4000003@qstreams.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Tsi-Chung Liew wrote: > Signed-off-by: TsiChung Liew > --- > drivers/net/mcffec.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/mcffec.c b/drivers/net/mcffec.c > index 3b81258..71d1960 100644 > --- a/drivers/net/mcffec.c > +++ b/drivers/net/mcffec.c > @@ -166,6 +166,13 @@ int fec_send(struct eth_device *dev, volatile void *packet, int length) > /* Activate transmit Buffer Descriptor polling */ > fecp->tdar = 0x01000000; /* Descriptor polling active */ > > + /* FEC fix for MCF5275, FEC unable to initial transmit data packet. > + * A nop will ensure the descriptor polling active completed. > + */ > +#ifdef CONFIG_M5275 > + __asm__ ("nop"); > +#endif > + > #ifdef CFG_UNIFY_CACHE > icache_invalid(); > #endif > Applied to net tree. As others have noted, adding a NOP here seems like a band-aid, but I can't really dispute it. thanks, Ben