From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Mon, 31 Mar 2008 10:21:20 -0400
Subject: [U-Boot-Users] [PATCH 08/13] SPARC: added SMC91111 driver in
 and out macros for LEON processors.
In-Reply-To: <1206973500-14282-1-git-send-email-daniel@gaisler.com>
References: <1206973500-14282-1-git-send-email-daniel@gaisler.com>
Message-ID: <47F0F360.4060507@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Daniel Hellstrom wrote:
> Ben Warren wrote:
>   
>> I haven't looked at how all the funky macros in this patch are called, but it's generally considered good form to wrap multi-line macros with do {...} while(0) in order to avoid compiler issues. I'll NAK the patch for now based on this.
>>     
>
> The Macros are used to read/write 8-,16-,32-bit words from the I/O bus where the SMC MAC is. 
> LEON2/3 is bigendian, so the macros swaps the read and written data as well. The I/O bus is
> non-cacheable so no force cache miss is needed here.
>
> I have made the do{}while(0) you asked for and updated patch 8 and my repository:
>
>
>   
Per the e-mail by A. Rubini, I guess this isn't necessary.  Sorry for 
causing extra work for you.  I'll pull this into the net tree today.

regards,
Ben