From: Andre Schwarz <andre.schwarz@matrix-vision.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add Vitesse 8601 support to TSEC driver
Date: Tue, 01 Apr 2008 13:38:34 +0200 [thread overview]
Message-ID: <47F21EBA.9030504@matrix-vision.de> (raw)
In-Reply-To: <20080331131830.bdd5c146.kim.phillips@freescale.com>
Kim,
would it help if we donate one or two boards to the custodians ?
Or do you have no time at all for specific testing ?
After bring-up + validation I could offer 1-2 MPC8343B based boards with
2x VSC8601.
The system also has a miniPCI Slot, USB-A and 512MB DDR-II Micron memory.
Please let me know if you're interested.
regards,
Andre Schwarz
Matrix Vision
Kim Phillips schrieb:
> On Mon, 31 Mar 2008 10:01:34 -0400
> Ben Warren <biggerbadderben@gmail.com> wrote:
>
>
>> Tor Krill wrote:
>>
>>> Add phy_info for Vitesse VSC8601.
>>> Add config option, CFG_VSC8601_SKEWFIX, to enable RGMII skew timing compensation.
>>>
>>> Signed-off-by: Tor Krill <tor@excito.com>
>>>
>>>
>> Acked-by: Ben Warren <biggerbadderben@gmail.com>
>>
>
> I don't have a Vitesse 8601, so technically I can't ack it, but I can:
>
> Reviewed-by: Kim Phillips <kim.phillips@freescale.com>
>
> minor nit: it would be nice if the following:
>
>
>>> +#ifdef CFG_VSC8601_SKEWFIX
>>> + {MIIM_VSC8601_EPHY_CON,MIIM_VSC8601_EPHY_CON_INIT_SKEW,NULL},
>>> +#endif
>>>
>
> were made to have spaces after commas, and flow onto a separate
> line so as to not be a 96 char line..
>
> Kim
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
>
MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090
Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20080401/7495f4a5/attachment.htm
next prev parent reply other threads:[~2008-04-01 11:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 14:29 [U-Boot-Users] [PATCH] Add Vitesse 8601 support to TSEC driver Tor Krill
2008-03-28 21:33 ` André Schwarz
2008-03-31 6:33 ` Tor Krill
2008-03-31 14:04 ` Ben Warren
2008-03-31 14:01 ` Ben Warren
2008-03-31 18:18 ` Kim Phillips
2008-04-01 11:38 ` Andre Schwarz [this message]
2008-04-17 18:32 ` Andre Schwarz
2008-04-18 8:40 ` Tor Krill
2008-04-24 14:23 ` Andre Schwarz
2008-04-01 13:33 ` Andre Schwarz
2008-04-01 13:42 ` Andy Fleming
2008-04-01 14:08 ` Andre Schwarz
2008-04-01 14:25 ` Andy Fleming
2008-04-01 14:35 ` Andre Schwarz
2008-04-01 16:12 ` Kim Phillips
2008-04-02 8:01 ` André Schwarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F21EBA.9030504@matrix-vision.de \
--to=andre.schwarz@matrix-vision.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox