[U-Boot-Users] [PATCH 0/2] MPC8xx: Fix libfdt support introduced in commit 77ff7b74

[Jerry Van Baren <gvb.uboot@gmail.com>]

Jean-Christophe PLAGNIOL-VILLARD wrote:
> fdt.c: In function 'ft_cpu_setup':
> fdt.c:33: warning: implicit declaration of function 'do_fixup_by_prop_u32'
> fdt.c:39: warning: implicit declaration of function 'do_fixup_by_compat_u32'
> fdt.c:43: warning: implicit declaration of function 'fdt_fixup_ethernet'
> fdt.c:45: warning: implicit declaration of function 'fdt_fixup_memory'
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> 
> diff --git a/cpu/mpc8xx/Makefile b/cpu/mpc8xx/Makefile
> index dbdc2e0..5f70459 100644
> --- a/cpu/mpc8xx/Makefile
> +++ b/cpu/mpc8xx/Makefile
> @@ -27,16 +27,29 @@ include $(TOPDIR)/config.mk
>  
>  LIB	= $(obj)lib$(CPU).a
>  
> -START	= start.o kgdb.o
> -COBJS	= bedbug_860.o commproc.o cpu.o cpu_init.o	\
> -	  fec.o fdt.o i2c.o interrupts.o lcd.o scc.o	\
> -	  serial.o speed.o spi.o \
> -	  traps.o upatch.o video.o
> -SOBJS	= plprcr_write.o
> -
> -SRCS	:= $(START:.o=.S) $(SOBJS:.o=.S) $(COBJS:.o=.c)
> -OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
> -START	:= $(addprefix $(obj),$(START))
> +START-y	+= start.o
> +START-y	+= kgdb.o
> +COBJS-y	+= bedbug_860.o
> +COBJS-y	+= commproc.o
> +COBJS-y	+= cpu.o
> +COBJS-y	+= cpu_init.o
> +COBJS-y	+= fec.o
> +COBJS-$(CONFIG_OF_LIBFDT) += fdt.o
> +COBJS-y	+= i2c.o
> +COBJS-y	+= interrupts.o
> +COBJS-y	+= lcd.o
> +COBJS-y	+= scc.o
> +COBJS-y	+= serial.o
> +COBJS-y	+= speed.o
> +COBJS-y	+= spi.o
> +COBJS-y	+= traps.o
> +COBJS-y	+= upatch.o
> +COBJS-y	+= video.o
> +SOBJS-y	+= plprcr_write.o
> +
> +SRCS	:= $(START-y:.o=.S) $(SOBJS-y:.o=.S) $(COBJS-y:.o=.c)
> +OBJS	:= $(addprefix $(obj),$(SOBJS-y) $(COBJS-y))
> +START	:= $(addprefix $(obj),$(START-y))
>  
>  all:	$(obj).depend $(START) $(LIB)

I did this too, but did not do as good a job (I did not change SOBJS to 
SOBJS-y and START to START-y).  Reference for my version:
   <http://article.gmane.org/gmane.comp.boot-loaders.u-boot/38885/>

I've replaced my version with J-C's version in u-boot-fdt.

Acked-by: Gerald Van Baren <vanbaren@cideas.com>

P.S. Thanks, Jean-Christophe, for doing a bunch of warning clean up.