From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Wed, 02 Apr 2008 11:29:36 -0400 Subject: [U-Boot-Users] [PATCH] Fix fdt set command to conform to dts spec In-Reply-To: <1207014356-1663-1-git-send-email-afleming@freescale.com> References: <1207014356-1663-1-git-send-email-afleming@freescale.com> Message-ID: <47F3A660.2060804@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Andy Fleming wrote: > The fdt set command was treating properties specified as <00> and <0011> > as byte streams, rather than as an array of cells. As we already have > syntax for expressing the desire for a stream of bytes ([ xx xx ...]), > we should use the <> syntax to describe arrays of cells, which are always > 32-bits per element. If we imagine this likely (IMHO) scenario: > >> fdt set /ethernet-phy at 1 reg <1> > > With the old code, this would create a bad fdt, since the reg cell would be > made to be one byte in length. But the cell must be 4 bytes, so this would > break mysteriously. Confirmed, my bad. Applied to the u-boot-fdt repo. Thanks, gvb