From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Sieka Date: Wed, 02 Apr 2008 17:59:48 +0200 Subject: [U-Boot-Users] [PATCH] Fix host tool build breakage, take two In-Reply-To: References: <20080401204126.31CD724544@gemini.denx.de> Message-ID: <47F3AD74.4000900@semihalf.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Kumar Gala wrote: > On Tue, 1 Apr 2008, Wolfgang Denk wrote: [...] >>> Any ideas on how to work around this? Do we really intend to pick up >>> the system md5.h or should we be getting the one from u-boot/include/ >>> md5.h? >> We need the system md5.h, I think. We'll investigate. > > If I force things to use the md5.h in u-boot/include things seem to build. > Here's the patch for the forcing: I think that generally it is a better idea to use U-Boot's includes when building for the host system, as this gives us better control over what exactly gets included. But then on the other hand, tools/Makefils has this: CPPFLAGS = -idirafter $(SRCTREE)/include \ -idirafter $(OBJTREE)/include2 \ -idirafter $(OBJTREE)/include \ Could anyone comment on the reasons why we try U-Boot's includes after system includes? Perhaps it would be a good idea to reverse the order -- see below for a quick RFC patch (compile-tested on two arm and two ppc boards, each arch with and without CONFIG_FIT enabled). Kumar - could you try the patch out and see if it helps your build issue? Regards, Bartlomiej diff --git a/tools/Makefile b/tools/Makefile index 8784a6d..93f74aa 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -117,7 +117,7 @@ BINS := $(addprefix $(obj),$(BIN_FILES)) # # Use native tools and options # -CPPFLAGS = -idirafter $(SRCTREE)/include \ +CPPFLAGS = -I $(SRCTREE)/include \ -idirafter $(OBJTREE)/include2 \ -idirafter $(OBJTREE)/include \ -DTEXT_BASE=$(TEXT_BASE) -DUSE_HOSTCC