From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17FD2EB64D9 for ; Thu, 6 Jul 2023 14:14:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C4DB785FDD; Thu, 6 Jul 2023 16:13:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="krYl3fdq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C443485C98; Thu, 6 Jul 2023 16:13:58 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CB57385C98 for ; Thu, 6 Jul 2023 16:13:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rogerq@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8D8BB6196B; Thu, 6 Jul 2023 14:13:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7C08C433C8; Thu, 6 Jul 2023 14:13:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688652834; bh=Q7cp3/3nM9HfS91e9RGN1cKdksvz0ESBGvnzs9gYqtY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=krYl3fdq3242bn24/RTAGcDrR5HR/8IXDfKCJAJq0j2XooCgiQmuJJYgCR+iORIzF lw8S2GqVNA8yDQ3/xh3AA5mqyl/qkS0TtDItNI1ggWvQ6K9BVOOnqapjvGr+d8DsbU SFElBJMGJD59aBqRcOyvXTVvz3bCW/blMLwE23AAOge4kWvTWrln82aH9dp4KsSCKp i3yzOp555Pwdn0J3GUIvGOIC0pNLydmByURyIe7BtNF4rgWShlz7mULnlXIFIxX6kZ wWppEuWbu+JXqBWgiRBgJtPu8AMiZKJ7admv7cJsgHjwmqeSyEzbgCmwah1qVm0m5Q NfcKOVVZyBcDQ== Message-ID: <47c4b9cd-c062-fe32-6aa8-cfa888cfc968@kernel.org> Date: Thu, 6 Jul 2023 17:13:50 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 3/6] arm: dts: k3-am642: Sync main_i2c0 with kernel Content-Language: en-US To: Nishanth Menon Cc: vigneshr@ti.com, trini@konsulko.com, srk@ti.com, u-boot@lists.denx.de References: <20230704181008.305561-1-rogerq@kernel.org> <20230704181008.305561-4-rogerq@kernel.org> <20230706123847.jtusg37dlskiiij3@educator> From: Roger Quadros In-Reply-To: <20230706123847.jtusg37dlskiiij3@educator> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Nishanth, On 06/07/2023 15:38, Nishanth Menon wrote: > On 21:10-20230704, Roger Quadros wrote: >> main_i2c0 and pinmux should be in k3-am642-evm.dts. >> Also add the I2C EEPROM. >> >> Signed-off-by: Roger Quadros >> --- >> arch/arm/dts/k3-am642-evm-u-boot.dtsi | 11 ----------- >> arch/arm/dts/k3-am642-evm.dts | 20 ++++++++++++++++++++ >> 2 files changed, 20 insertions(+), 11 deletions(-) >> >> diff --git a/arch/arm/dts/k3-am642-evm-u-boot.dtsi b/arch/arm/dts/k3-am642-evm-u-boot.dtsi >> index 64857b0909..80c04d0117 100644 >> --- a/arch/arm/dts/k3-am642-evm-u-boot.dtsi >> +++ b/arch/arm/dts/k3-am642-evm-u-boot.dtsi >> @@ -34,21 +34,10 @@ >> >> &main_pmx0 { >> bootph-pre-ram; >> - main_i2c0_pins_default: main-i2c0-pins-default { >> - bootph-pre-ram; >> - pinctrl-single,pins = < >> - AM64X_IOPAD(0x0260, PIN_INPUT_PULLUP, 0) /* (A18) I2C0_SCL */ >> - AM64X_IOPAD(0x0264, PIN_INPUT_PULLUP, 0) /* (B18) I2C0_SDA */ >> - >; >> - }; >> }; >> >> &main_i2c0 { >> - status = "okay"; >> bootph-pre-ram; >> - pinctrl-names = "default"; >> - pinctrl-0 = <&main_i2c0_pins_default>; >> - clock-frequency = <400000>; >> }; >> >> &main_uart0 { >> diff --git a/arch/arm/dts/k3-am642-evm.dts b/arch/arm/dts/k3-am642-evm.dts >> index 39feea78a0..529eb81538 100644 >> --- a/arch/arm/dts/k3-am642-evm.dts >> +++ b/arch/arm/dts/k3-am642-evm.dts >> @@ -233,6 +233,13 @@ >> >; >> }; >> >> + main_i2c0_pins_default: main-i2c0-default-pins { >> + pinctrl-single,pins = < >> + AM64X_IOPAD(0x0260, PIN_INPUT_PULLUP, 0) /* (A18) I2C0_SCL */ >> + AM64X_IOPAD(0x0264, PIN_INPUT_PULLUP, 0) /* (B18) I2C0_SDA */ >> + >; >> + }; >> + >> main_i2c1_pins_default: main-i2c1-pins-default { >> pinctrl-single,pins = < >> AM64X_IOPAD(0x0268, PIN_INPUT_PULLUP, 0) /* (C18) I2C1_SCL */ >> @@ -335,6 +342,19 @@ >> status = "reserved"; >> }; >> >> +&main_i2c0 { >> + status = "okay"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&main_i2c0_pins_default>; >> + clock-frequency = <400000>; >> + >> + eeprom@50 { >> + /* AT24CM01 */ >> + compatible = "atmel,24c1024"; >> + reg = <0x50>; >> + }; >> +}; >> + >> &main_i2c1 { >> status = "okay"; >> pinctrl-names = "default"; >> -- >> 2.34.1 >> > > We should be getting this change again as part of sync back from kernel. > > Got it. Adding the EEPROM node causes I2C timeout error prints like below. Any clue why that would be the case? Timed out in wait_for_event: status=0000 Check if pads/pull-ups of bus are properly configured EEPROM not available at 0x50, trying to read at 0x51 Timed out in wait_for_event: status=0000 Check if pads/pull-ups of bus are properly configured Reading on-board EEPROM at 0x51 failed -121 -- cheers, -roger