From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 14 Apr 2008 14:55:24 -0500 Subject: [U-Boot-Users] [PATCH 1/2] Don't panic if a controller driver does ecc its own way. In-Reply-To: <20080414195050.0DC4B248B9@gemini.denx.de> References: <20080414195050.0DC4B248B9@gemini.denx.de> Message-ID: <4803B6AC.50603@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > In message <20080414163455.GA7061@ld0162-tx32.am.freescale.net> you wrote: >>>> Some hardware, such as the enhanced local bus controller used on some >>>> mpc83xx chips, does ecc transparently when reading and writing data, rather >>>> than providing a generic calculate/correct mechanism that can be exported to >>>> the nand subsystem. >>>> >>>> The subsystem should not BUG() when calculate, correct, or hwctl are >>>> missing, if the methods that call them have been overridden. >>>> >>>> Signed-off-by: Scott Wood >>> This should go through the 83xx custodian, but I haven't seen this >>> yet? >> Why should it go through 83xx? It's a patch against generic NAND code. > > It seems to be 83xx specific code to me? It's not. It is removing a restriction in the NAND code that happens to interfere with what the FSL NAND driver needs to do. >> Did you try applying it against the 2.6.22.1 branch of the nand >> repository (IIRC, the non-commit-message patch comment specified that)? > > No, I tried to apply this to the U-Boot repository. Maybe this was my > fault? Is this supposed to go into Linux, then? No, it's supposed to go into the 2.6.22.1 branch of Stefan's u-boot NAND tree. This change is already in the Linux NAND code. -Scott