public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: michael <trimarchi@gandalf.sssup.it>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] USB SUPPORT
Date: Mon, 21 Apr 2008 18:56:28 +0200	[thread overview]
Message-ID: <480CC73C.8000509@gandalf.sssup.it> (raw)
In-Reply-To: <AA28F077645B324881335614E4F7C428034CD1@win-ex01.bench.com>

Hi,
> #define CONFIG_SUPPORT_VFAT
>
> --- FAT16 vs. FAT32 - Atmel U-Boot v1.1.5 issue? ---
>
> I have found that the USB support is better
> when the USB Storage device is FAT16 formatted
> rather than FAT32 formatted.  For some reason
> not all files were accessible on FAT32
> formatted media, but I never had any problem
> with FAT16 formatted media.
>
> Sincerely,
>
> Ken Fuchs
>
>   
Can you try this patch?
In the git log there is another patch for vfat to be applied.
Regards Michael

Check if the entry is a valid dir_slot entry, otherwise it is a dentry 
and the
name has to be taken by the get_name function

Signed-off-by: michael trimarchi <trimarchi@gandalf.sssup.it>

---
 fs/fat/fat.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/fs/fat/fat.c b/fs/fat/fat.c
index 49c78ed..ddee823 100644
--- a/fs/fat/fat.c
+++ b/fs/fat/fat.c
@@ -470,6 +470,12 @@ get_vfatname(fsdata *mydata, int curclust, __u8 
*cluster,
             return -1;
         }
         slotptr2 = (dir_slot*) get_vfatname_block;
+        if (slotptr2->attr != ATTR_VFAT) {
+            realdent = (dir_entry *)get_vfatname_block;
+            get_name ((dir_entry *)get_vfatname_block, l_name);
+            goto out;
+        }
+
         while (slotptr2->id > 0x01) {
             slotptr2++;
         }
@@ -494,6 +500,7 @@ get_vfatname(fsdata *mydata, int curclust, __u8 
*cluster,
     else if (*l_name == aRING) *l_name = '?';
     downcase(l_name);
 
+out:
     /* Return the real directory entry */
     memcpy(retdent, realdent, sizeof(dir_entry));
 
-- 1.5.2.1.174.gcd03-dirty

  reply	other threads:[~2008-04-21 16:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-21  4:29 [U-Boot-Users] USB SUPPORT Aneesh
2008-04-21 15:04 ` Markus Klotzbücher
2008-04-21 16:36 ` Ken.Fuchs at bench.com
2008-04-21 16:56   ` michael [this message]
2008-04-21 22:53     ` Ken.Fuchs at bench.com
2008-04-22  7:53       ` michael
2008-04-22 22:31         ` Ken.Fuchs at bench.com
2008-04-23  6:54           ` michael
2008-04-23  8:14             ` michael
2008-04-23 11:15               ` [U-Boot-Users] USB SUPPORT & get_vfatname michael
2008-04-23 18:01                 ` Ken.Fuchs at bench.com
2008-04-24  7:59                   ` michael
2008-04-24 16:13                     ` Ken.Fuchs at bench.com
2008-04-24 17:01                       ` michael
2008-04-24 21:30                         ` Ken.Fuchs at bench.com
  -- strict thread matches above, loose matches on Subject: below --
2006-11-17 17:38 [U-Boot-Users] USB Support Ajay Jain
2004-10-04 15:27 [U-Boot-Users] Usb support swamy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=480CC73C.8000509@gandalf.sssup.it \
    --to=trimarchi@gandalf.sssup.it \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox