From: Jens Gehrlein <sew_s@tqs.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] net: add 16 bit support for smc911x
Date: Wed, 30 Apr 2008 07:20:52 +0200 [thread overview]
Message-ID: <481801B4.10500@tqs.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0804292208520.8498@axis700.grange>
Guennadi Liakhovetski schrieb:
> On Tue, 29 Apr 2008, Jens Gehrlein wrote:
>
>> Hi Ben, Magnus,
>>
>> here is my patch to enable 2x16 bit accesses to the LAN9x1x.
>> I still not have a HW, so may I ask you to test it and, if applicable,
>> fix the code?
>>
>> Best Regards,
>> Jens
>>
>> ---
>>
>> drivers/net/smc911x.c | 17 ++++++++++++++++-
>> 1 files changed, 16 insertions(+), 1 deletions(-)
>>
>>
>> diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
>> index d22c889..841a64d 100644
>> --- a/drivers/net/smc911x.c
>> +++ b/drivers/net/smc911x.c
>> @@ -30,6 +30,8 @@
>> #include <net.h>
>> #include <miiphy.h>
>>
>> +#define CONFIG_DRIVER_SMC911X_16_BIT 1
>> +
>
> Looks like an obvious thing - you'll remove this define from the patch for
> final submission, right?
Oh, ah. You're right. I inserted this to do a compile test and to
inspect the generated assembler code. This define should be later moved
to the board specific header file.
Sorry.
Well spotted. Thank you.
Magnus, are you going to fix the code as proposed by Ben and Guennadi or
should I resubmit the patch?
Best Regards,
Jens
next prev parent reply other threads:[~2008-04-30 5:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 10:15 [U-Boot-Users] [PATCH] net: add 16 bit support for smc911x Jens Gehrlein
2008-04-29 14:43 ` Ben Warren
2008-04-29 14:59 ` Magnus Lilja
2008-04-29 17:23 ` Ben Warren
2008-04-29 20:10 ` Guennadi Liakhovetski
2008-04-30 5:20 ` Jens Gehrlein [this message]
2008-04-30 6:11 ` Ben Warren
2008-04-30 8:12 ` Magnus Lilja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481801B4.10500@tqs.de \
--to=sew_s@tqs.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox