From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B9F0C6FD1D for ; Sat, 1 Apr 2023 22:44:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8F1C28575B; Sun, 2 Apr 2023 00:44:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="e/t9lnjq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1D8CF854E0; Sun, 2 Apr 2023 00:44:22 +0200 (CEST) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 395F3857F0 for ; Sun, 2 Apr 2023 00:44:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=francis.laniel@amarulasolutions.com Received: by mail-wm1-x343.google.com with SMTP id i5-20020a05600c354500b003edd24054e0so17565191wmq.4 for ; Sat, 01 Apr 2023 15:44:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1680389053; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sXhSL9q0IQ15pAbpnpipXd5CYrTVKO2/hYIz2qIPfUM=; b=e/t9lnjqTulzv1XAMgR6uosc4hJTVkuFTCvvAX9Fv+4fLRyHOYycBGzwYE2dGxPNJg IGdlzilHCRMyD5taKTUtgmU3C1r68xFOcbjVZ5enNk18fZxe4xOpzT+xWtfsOMGoAEmN J8qkr3Ah8WEDF2Zpi9Gw0kHzw1W0PKMC83dn4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680389053; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sXhSL9q0IQ15pAbpnpipXd5CYrTVKO2/hYIz2qIPfUM=; b=pEiZi4T7WtPvRJk+dfS+JDDes1VlvA1UUK0o1j/iYkM9fRlJyfP+c4hKKVEm8r217d HAh5Iwc5srrb1krs2AWrRy/x9jbCD5mnpOibWeCJI5khjXG1B69suJmK/jy/yJPO9jf+ 558dfOOzMY8UWGYZDNtq6uT3g2mFt6P6bOBeCkrDNAafxt8NrGM36ogTYnGFJP5g/bG3 XGtQMCNFovxBjvi8Z73HVB04v8P1GfWxJVnU6hy4dVp82lysRE020PIF+onWjIjbQRf2 LXu4aQfhYhggfs9WIhFDqNrIaMm0pvTo4v9MnLQpg5w5/SJrFjP32Jj4xQh42//vHBil 2dcQ== X-Gm-Message-State: AO0yUKU/0btA4L3dt3BNSxn3vSBgDmFtt7nHIbMvIrlH0/bVTU6ByyAA +/jqDMRj9wd8WSqhK8Jg2U4i2g== X-Google-Smtp-Source: AK7set9qqYxy8fUAG3P4IZBxOIWeeA6PijexUEmzttbTrz+/x4NDwKkRWJjkOOldzcmlhMD72i00qQ== X-Received: by 2002:a05:600c:3642:b0:3e2:1d1e:78d6 with SMTP id y2-20020a05600c364200b003e21d1e78d6mr23520705wmq.7.1680389053322; Sat, 01 Apr 2023 15:44:13 -0700 (PDT) Received: from pwmachine.localnet ([78.30.11.60]) by smtp.gmail.com with ESMTPSA id u17-20020a05600c19d100b003dd1bd0b915sm14616788wmq.22.2023.04.01.15.44.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Apr 2023 15:44:12 -0700 (PDT) From: Francis Laniel To: Simon Glass Cc: u-boot@lists.denx.de, Michael Nazzareno Trimarchi , Tom Rini , Harald Seiler , "Albert ARIBAUD (3ADEV)" , Tony Dinh , Sergei Antonov , Ilias Apalodimas , Heinrich Schuchardt , Masahisa Kojima , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Stefan Roese , John Keeping , Roger Knecht , Neil Armstrong , Robert Marko , Alexey Romanov , Fabrice Gasnier , Patrick Delaunay , Marek Vasut , Hector Palacios , Rasmus Villemoes , AKASHI Takahiro , Linus Walleij , Rui Miguel Silva , Andrew Scull Subject: Re: [RFC PATCH v7 11/23] cmd: Add new parser command Date: Sat, 01 Apr 2023 23:44:10 +0100 Message-ID: <4819006.31r3eYUQgx@pwmachine> In-Reply-To: References: <20230330194716.23623-1-francis.laniel@amarulasolutions.com> <20230330194716.23623-12-francis.laniel@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi. Le samedi 1 avril 2023, 07:32:14 WEST Simon Glass a =E9crit : > Hi Francis, >=20 > On Fri, 31 Mar 2023 at 08:49, Francis Laniel >=20 > wrote: > > This command can be used to print the current parser with 'parser print= '. > > It can also be used to set the current parser with 'parser set'. > > For the moment, only one value is valid for set: old. > >=20 > > Signed-off-by: Francis Laniel > > --- > >=20 > > cmd/Makefile | 2 + > > cmd/parser.c | 120 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > common/cli.c | 3 +- > > 3 files changed, 124 insertions(+), 1 deletion(-) > > create mode 100644 cmd/parser.c >=20 > Reviewed-by: Simon Glass Thank you for the reviews! >=20 > But I wonder whether 'cli' might be a better name for this command? We > use cli everywhere else. "Naming thing is hard" [1]. Thank you for the suggestion! I changed it to cli which I think is a better= =20 name as it is less abstract than parser. > Also can you add doc/usage for this? Done! I was not aware of doc/usage/cmd before. > Regards, > Simon By the way, I also addressed your other comments on patches 4 and 9. Best regards. =2D-- [1] https://www.karlton.org/2017/12/naming-things-hard/