public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] ColdFire: Get information from the correct GCC
Date: Thu, 01 May 2008 12:42:47 +0900	[thread overview]
Message-ID: <48193C37.6030106@ruby.dti.ne.jp> (raw)
In-Reply-To: <1209575423-1244-1-git-send-email-Tsi-Chung.Liew@freescale.com>

Tsi-Chung Liew wrote:
>  cpu/mcf523x/config.mk    |    2 +-
>  cpu/mcf52x2/config.mk    |    2 +-
>  cpu/mcf532x/config.mk    |    2 +-
>  cpu/mcf5445x/config.mk   |    2 +-
>  cpu/mcf547x_8x/config.mk |    2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/cpu/mcf5227x/config.mk b/cpu/mcf5227x/config.mk
> index 8d60fd6..2e50696 100644
> --- a/cpu/mcf5227x/config.mk
> +++ b/cpu/mcf5227x/config.mk
> @@ -24,7 +24,7 @@
>  #
>  
>  PLATFORM_RELFLAGS += -ffixed-d7 -msep-data
> -ifeq ($(findstring 4.2,$(shell $(CC) --version)),4.2)
> +ifeq ($(findstring 4.2,$(shell $(CROSS_COMPILE)gcc --version)),4.2)
>  PLATFORM_CPPFLAGS += -mcpu=5208 -fPIC
>  else
>  PLATFORM_CPPFLAGS += -m5307 -fPIC

Let me make sure the intention of this change. With or without this
change, we can always evaluate $(CROSS_COMPILE)gcc --version, right?
Or am I missing something?

There are several $(CC)/$(AR)/$(AS)/$(CPP) users in cpu/*/Makefile &
cpu/*/config.mk. I'm wondering whether we need to fix all these usages
or not.

Thanks in advance,

  Shinya

  parent reply	other threads:[~2008-05-01  3:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 17:10 [U-Boot-Users] [PATCH] ColdFire: Get information from the correct GCC Tsi-Chung Liew
2008-04-30 20:36 ` Wolfgang Denk
2008-05-01  3:42 ` Shinya Kuribayashi [this message]
2008-05-01 21:34   ` Liew Tsi Chung
2008-05-01 22:05     ` Wolfgang Denk
2008-05-02 22:03       ` Liew Tsi Chung
2008-05-02 22:57         ` Wolfgang Denk
2008-05-03  3:25         ` Shinya Kuribayashi
2008-05-04  5:37           ` Liew Tsi Chung
2008-05-04  5:49             ` Shinya Kuribayashi
2008-05-04  8:37               ` Liew Tsi Chung
2008-05-04  9:56                 ` Shinya Kuribayashi
2008-05-04 16:34                   ` Kurt Mahan
2008-05-04 18:44                     ` Wolfgang Denk
2008-05-06  9:32                     ` Shinya Kuribayashi
2008-05-05 14:14                   ` Liew Tsi Chung
2008-05-05 22:02                     ` Wolfgang Denk
2008-05-06  6:41                       ` Liew Tsi Chung
2008-05-05 15:43                   ` Liew Tsi Chung
2008-05-04 15:40                 ` Wolfgang Denk
2008-05-03 21:11   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48193C37.6030106@ruby.dti.ne.jp \
    --to=skuribay@ruby.dti.ne.jp \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox