From mboxrd@z Thu Jan 1 00:00:00 1970 From: Larry Johnson Date: Mon, 05 May 2008 11:34:20 -0400 Subject: [U-Boot-Users] [PATCH][RFC] pci: Remove CONFIG_PCI_SKIP_HOST_BRIDGE and Add check PCI class of host bridge In-Reply-To: <20080428170042.386ac2d6.iwamatsu@nigauri.org> References: <480883E6.5000304@matrix-vision.de> <4808AD5C.8080202@acm.org> <200804181657.16177.sr@denx.de> <20080428170042.386ac2d6.iwamatsu@nigauri.org> Message-ID: <481F28FC.3040103@acm.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Nobuhiro Iwamatsu wrote: > Hi, all. > > Sorry for the delay. > > On Fri, 18 Apr 2008 16:57:15 +0200 > Stefan Roese wrote: > >>> The patch changes the behavior of the code _unless_ >>> CONFIG_PCI_SKIP_HOST_BRIDGE is defined. Defining that switch in the >>> Korat configuration fixes the problem. The MPC8323ERDB configuration >>> has also been patched to add the switch, so maybe this is is the cause >>> of your problem as well. >>> >>> I was going to submit the patch for Korat, but then decided I'd first >>> like to ask Nobuhiro and the group whether it might not be better to >>> change the occurrences of >>> >>> #if defined(CONFIG_PCI_SKIP_HOST_BRIDGE) >>> >>> in "drivers/pci/pci.c" to >>> >>> #if !defined(CONFIG_PCI_NO_SKIP_HOST_BRIDGE) >>> >>> That would allow those boards that need to patch to specify it >>> explicity, while leaving the default functionality unchanged. >>> >>> Comments? >> Yes, I totally agree. Patches should *not* change the default behavior. We >> should change it as you suggested. Sorry, I must have missed this. >> >> Nobuhiro, could you please send a new patch to fix this problem? > > Thank you for your check. > It has troubled you with my patch. > > I rewirte new patch . Could you please check this patch and confirming the work? > > Best regards, > Nobuhiro Hi Nobuhiro, Stefan, and everyone, Sorry for the delay in getting back to you. My mail reader thinks your patch is part of your signature, so I missed it the first time around. I did a quick check using the Sequoia board, and it looks like the patch isn't working there. U-Boot is reporting the class of the bridge as "0680", which I assume is why the patch doesn't skip it. Nobuhiro and Stefan, do you think we can get a working fix for this into 1.3.3 (even if it is not the final fix)? If not, we should patch Sequoia and Korat to add CONFIG_PCI_SKIP_HOST_BRIDGE so they won't be broken in that release. Best regards, Larry