From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerry Van Baren <gerald.vanbaren@ge.com>
Date: Fri, 09 May 2008 14:45:59 -0400
Subject: [U-Boot-Users] [PATCH 2/4 V2] PPC: Change lib_ppc/bat_rw.c to
 use high bats
In-Reply-To: <6514CE95-5C25-4C36-88DA-63E03DE87024@freescale.com>
References: <1210291343-12478-1-git-send-email-Becky.bruce@freescale.com>	<20080509152806.GA30510@ld0162-tx32.am.freescale.net>
	<6514CE95-5C25-4C36-88DA-63E03DE87024@freescale.com>
Message-ID: <48249BE7.4090702@ge.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Becky Bruce wrote:
> On May 9, 2008, at 10:28 AM, Scott Wood wrote:
>> On Thu, May 08, 2008 at 07:02:23PM -0500, Becky.bruce at freescale.com  
>> wrote:
>>> diff --git a/include/asm-ppc/mmu.h b/include/asm-ppc/mmu.h
>>> index 49d6860..f836270 100644
>>> --- a/include/asm-ppc/mmu.h
>>> +++ b/include/asm-ppc/mmu.h
>>> @@ -141,6 +141,10 @@ extern void _tlbia(void);		/* invalidate all  
>>> TLB entries */
>>> typedef enum {
>>> 	IBAT0 = 0, IBAT1, IBAT2, IBAT3,
>>> 	DBAT0, DBAT1, DBAT2, DBAT3
>>> +#ifdef CONFIG_HIGH_BATS
>>> +	, IBAT4, IBAT5, IBAT6, IBAT7,
>>> +	DBAT4, DBAT5, DBAT6, DBAT7
>>> +#endif
>> C allows trailing commas on such lists; no need to move it inside the
>> ifdef.
> 
> Dangling commas bother me in the extreme.  If this is the concensus,  
> I'll move it, but I prefer it where it is.
> 
> -B

+1 for moving.  Dangling commas is the second best thing in C. ;-)

Best regards,
gvb