public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Morten Ebbell Hestnes <morten.hestnes@tandberg.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] NAND read/write.jffs2 fix
Date: Thu, 15 May 2008 17:26:46 +0200	[thread overview]
Message-ID: <482C5636.1090403@tandberg.com> (raw)
In-Reply-To: <20080514124050.1e51e1b2.kim.phillips@freescale.com>

Hi Kim,

Kim Phillips wrote:
> On Tue, 13 May 2008 15:41:06 -0500
> Scott Wood <scottwood@freescale.com> wrote:
> 
>>>  
>>>  static int nand_dump(nand_info_t *nand, ulong off, int only_oob)
>>>  {
>>> @@ -73,9 +74,9 @@ static int nand_dump(nand_info_t *nand, ulong off, int only_oob)
>>>  	while (i--) {
>>>  		if (!only_oob) {
>>>  			printf( "\t%02x %02x %02x %02x %02x %02x %02x %02x"
>>> -					"  %02x %02x %02x %02x %02x %02x %02x %02x\n",
>>> -					p[0], p[1], p[2], p[3], p[4], p[5], p[6], p[7],
>>> -					p[8], p[9], p[10], p[11], p[12], p[13], p[14], p[15]);
>>> +				"  %02x %02x %02x %02x %02x %02x %02x %02x\n",
>>> +				p[0], p[1], p[2], p[3], p[4], p[5], p[6], p[7],
>>> +				p[8], p[9], p[10], p[11], p[12], p[13], p[14], p[15]);
>> Still exceeds 80 characters on the last line.
> 
> or use lib_generic/display_options.c:print_buffer()

806b4da8: ff ff 01 10 00 00 05 01    ........
or
        ff ff 01 10 00 00 05 01

The 806b4da8 is a address RAM address and has nothing to do with the nand offset.
I think the last printout is better.

Morten

  reply	other threads:[~2008-05-15 15:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 11:49 [U-Boot-Users] [PATCH] NAND read/write.jffs2 fix Morten Ebbell Hestens
2008-05-13 20:41 ` Scott Wood
2008-05-14 17:40   ` Kim Phillips
2008-05-15 15:26     ` Morten Ebbell Hestnes [this message]
2008-05-16  9:22   ` Morten Ebbell Hestnes
2008-05-16 16:45     ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482C5636.1090403@tandberg.com \
    --to=morten.hestnes@tandberg.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox