From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Thu, 15 May 2008 13:50:07 -0700 Subject: [U-Boot-Users] [PATCH 1/1] Fix 8313ERDB board configuration In-Reply-To: <12108831871831-git-send-email-yorksun@freescale.com> References: <12108831871831-git-send-email-yorksun@freescale.com> Message-ID: <482CA1FF.4090505@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi York, York Sun wrote: > Change LCRR clock ratio from 2 to 4 to commodate VSC7385. > Correct TSEC1 vs TSEC2 assignment. > Define ETHADDR and ETH1ADDR always. > > Signed-off-by: York Sun > Signed-off-by: Timur Tabi > --- > include/configs/MPC8313ERDB.h | 14 ++++++-------- > 1 files changed, 6 insertions(+), 8 deletions(-) > > diff --git a/include/configs/MPC8313ERDB.h b/include/configs/MPC8313ERDB.h > index 6eec240..f9fa535 100644 > --- a/include/configs/MPC8313ERDB.h > +++ b/include/configs/MPC8313ERDB.h > @@ -42,9 +42,12 @@ > > /* > * On-board devices > + * > + * TSEC1 is VSC switch > + * TSEC2 is SoC TSEC > */ > #define CONFIG_VSC7385_ENET > - > +#define CONFIG_TSEC2 > > #ifdef CFG_66MHZ > #define CONFIG_83XX_CLKIN 66666667 /* in Hz */ > @@ -80,7 +83,7 @@ > > #ifdef CONFIG_VSC7385_ENET > > -#define CONFIG_TSEC2 > +#define CONFIG_TSEC1 > > /* The flash address and size of the VSC7385 firmware image */ > #define CONFIG_VSC7385_IMAGE 0xFE7FE000 > @@ -209,7 +212,7 @@ > /* > * Local Bus LCRR and LBCR regs > */ > -#define CFG_LCRR LCRR_EADC_1 | LCRR_CLKDIV_2 /* 0x00010002 */ > +#define CFG_LCRR LCRR_EADC_1 | LCRR_CLKDIV_4 > #define CFG_LBC_LBCR ( 0x00040000 /* TODO */ \ > | (0xFF << LBCR_BMT_SHIFT) \ > | 0xF ) /* 0x0004ff0f */ > @@ -523,13 +526,8 @@ > */ > #define CONFIG_ENV_OVERWRITE > > -#ifdef CONFIG_HAS_ETH0 > #define CONFIG_ETHADDR 00:E0:0C:00:95:01 > -#endif > - > -#ifdef CONFIG_HAS_ETH1 > #define CONFIG_ETH1ADDR 00:E0:0C:00:95:02 > -#endif > Please also remove the default MAC address assignments. > > #define CONFIG_IPADDR 10.0.0.2 > #define CONFIG_SERVERIP 10.0.0.1 > While you're at it, putting default IP addresses is also pointless. regards, Ben