From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Thu, 15 May 2008 17:26:08 -0500 Subject: [U-Boot-Users] [PATCH 1/1] Fix 8313ERDB board configuration In-Reply-To: <20080515222212.1005F247A5@gemini.denx.de> References: <20080515222212.1005F247A5@gemini.denx.de> Message-ID: <482CB880.6050300@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > In message <1210886469.880.45.camel@laptop> you wrote: >>> Please also remove the default MAC address assignments. >> I think we need them, don't we? > > No, or you can install this U-Boot image exactly on one specific, > single board. I understand your argument, but it's rather disingenuous when you allow this code to exist: #ifdef CONFIG_ETHADDR "ethaddr=" MK_STR(CONFIG_ETHADDR) "\0" #endif #ifdef CONFIG_ETH1ADDR "eth1addr=" MK_STR(CONFIG_ETH1ADDR) "\0" #endif #ifdef CONFIG_ETH2ADDR "eth2addr=" MK_STR(CONFIG_ETH2ADDR) "\0" #endif #ifdef CONFIG_ETH3ADDR "eth3addr=" MK_STR(CONFIG_ETH3ADDR) "\0" #endif #ifdef CONFIG_IPADDR "ipaddr=" MK_STR(CONFIG_IPADDR) "\0" #endif #ifdef CONFIG_SERVERIP "serverip=" MK_STR(CONFIG_SERVERIP) "\0" #endif If you get rid of this block, you'll solve the problem for all boards, instead of nagging people who post patches for unrelated bugs. -- Timur Tabi Linux kernel developer at Freescale