public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH][resubmit] MPC85xx, MPC83xx: Add/Fix UPM configuration support
Date: Mon, 19 May 2008 15:32:22 -0400	[thread overview]
Message-ID: <4831D5C6.4000106@ge.com> (raw)
In-Reply-To: <3026DA9FE767E2418FA2C568FE4F5CB17713D3C2F7@ILPTMAIL02.ecitele.com>

David Saada wrote:
> Add support for UPM configuration on the 85xx platform.
> In addition, on the MPC83xx, remove MPC834x precompiler condition, in 
> order to support all MPC83xx processors.
>  
> Signed-off-by: David Saada <david.saada@ecitele.com>

Bad news, David, I think I mislead you with my Option #1 - it looks 
sorta OK, but it still is full of bad stuff, including line wraps, when 
you look at the actual text of the email.

This is a snippet of the email source (text version, the HTML version is 
not even worth pasting in)

> cpu/mpc83xx/cpu.c |    5 ----
> cpu/mpc85xx/cpu.c |   66 ++++++++++++++++++++++++++++++++++++++++++++++++++=
> ++++
> include/mpc85xx.h |    7 ++++-
> 3 files changed, 72 insertions(+), 6 deletions(-)
> 
> --- a/cpu/mpc83xx/cpu.c 2008-05-15 01:42:46.000000000 +0300
> +++ b/cpu/mpc83xx/cpu.c 2008-05-18 11:22:34.503036000 +0300
> @@ -147,7 +147,6 @@ int checkcpu(void)
>   */
>  void upmconfig (uint upm, uint *table, uint size)
>  {
> -#if defined(CONFIG_MPC834X)
>         volatile immap_t *immap =3D (immap_t *) CFG_IMMR;
>         volatile lbus83xx_t *lbus =3D &immap->lbus;
>         volatile uchar *dummy =3D NULL;
> @@ -180,10 +179,6 @@ void upmconfig (uint upm, uint *table, u
> 
>         /* Set the OP field in the MxMR to "normal" and the MAD field to 00=
> 0000 */

Note the above is linewrapped with quoted printable "stuff" in it.

>         *mxmr &=3D 0xCFFFFFC0;

The =3D is more quoted printable "stuff."

> -#else
> -       printf("Error: %s() not defined for this configuration.\n", __FUNCT=
> ION__);

More line wrapped q-p "stuff."

> -       hang();
> -#endif
>  }

Sorry for getting your hopes up.  Try finding an open port 25.  :-/

Best regards,
gvb

  reply	other threads:[~2008-05-19 19:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-19 16:05 [U-Boot-Users] [PATCH][resubmit] MPC85xx, MPC83xx: Add/Fix UPM configuration support David Saada
2008-05-19 19:32 ` Jerry Van Baren [this message]
2008-05-20  7:15   ` David Saada
2008-05-20 12:44     ` Jerry Van Baren
2008-05-20 15:50       ` Kim Phillips
     [not found]       ` <2acbd3e40805200827x241dfd49v2bb620935f73d71b@mail.gmail.com>
2008-05-20 16:07         ` Jerry Van Baren
2008-05-19 22:26 ` Kim Phillips
2008-05-20  7:32   ` David Saada
2008-05-20 15:45     ` Kim Phillips
2008-06-11 21:21 ` Andy Fleming
2008-06-15 12:26   ` David Saada
  -- strict thread matches above, loose matches on Subject: below --
2008-03-31  8:47 David Saada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4831D5C6.4000106@ge.com \
    --to=gerald.vanbaren@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox