From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] mips: tolerate the MIPS 'CFG_HZ' valuesin the MHZ range for NAND delays
Date: Mon, 19 May 2008 15:36:15 -0500 [thread overview]
Message-ID: <4831E4BF.3020306@freescale.com> (raw)
In-Reply-To: <1211229110.3617.2.camel@mcmullan-linux.cifs.lab.netapp.com>
McMullan, Jason wrote:
> On Mon, 2008-05-19 at 15:26 -0500, Scott Wood wrote:
>> Even though it's MIPS that needs it, it should be flagged as a NAND
>> patch since that's the code it touches.
>
> Totally agree.
>
>> How about this?
>>
>> if (state == FL_ERASING)
>> timeo = CFG_HZ * 2 / 5;
>> else
>> timeo = CFG_HZ / 50
>>
>> If we have CFG_HZ values that are within a factor of 2 of wrapping
>> around, the platform should probably do some downward scaling (or we
>> should think about 64-bit timestamps)...
>
>
> Much better than my original patch. Should I revert, retry, and resend?
Sure.
-Scott
next prev parent reply other threads:[~2008-05-19 20:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 18:24 [U-Boot-Users] [PATCH] mips: tolerate the MIPS 'CFG_HZ' values in the MHZ range for NAND delays Jason McMullan
2008-05-19 20:26 ` Scott Wood
2008-05-19 20:31 ` [U-Boot-Users] [PATCH] mips: tolerate the MIPS 'CFG_HZ' valuesin " McMullan, Jason
2008-05-19 20:36 ` Scott Wood [this message]
2008-05-19 20:39 ` [U-Boot-Users] [PATCH] mips: tolerate the MIPS 'CFG_HZ' values in " Wolfgang Denk
2008-05-19 20:43 ` Scott Wood
2008-05-19 20:51 ` Wolfgang Denk
2008-05-19 21:15 ` Scott Wood
2008-06-11 23:02 ` Wolfgang Denk
2008-05-19 20:38 ` Wolfgang Denk
2008-05-20 8:27 ` Haavard Skinnemoen
2008-05-20 8:34 ` Wolfgang Denk
2008-05-20 9:22 ` Haavard Skinnemoen
2008-05-20 9:31 ` Wolfgang Denk
2008-05-19 20:44 ` Alessandro Rubini
2008-05-19 20:53 ` Wolfgang Denk
2008-05-19 21:04 ` Alessandro Rubini
2008-05-19 21:14 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4831E4BF.3020306@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox