From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 19 May 2008 16:15:26 -0500 Subject: [U-Boot-Users] [PATCH] mips: tolerate the MIPS 'CFG_HZ' values in the MHZ range for NAND delays In-Reply-To: <20080519205130.9A52D2476E@gemini.denx.de> References: <20080519205130.9A52D2476E@gemini.denx.de> Message-ID: <4831EDEE.4010706@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > In message <4831E665.3030003@freescale.com> you wrote: >>> Broken ports should be fixed. >> Maybe we should define it in a non-board-specific header, so as to make >> the intent clear that it not actually be configurable? > > Good idea. But the change fill break some 100 boards. Yeah, I didn't say it'd be painless. :-) How about something like this: #ifndef CFG_HZ #define CFG_HZ 1000 #elif CFG_HZ != 1000 #warning CFG_HZ must be 1000 #endif -Scott