public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Christian Eggers <ceggers@gmx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Fix endianess conversion in usb_ohci.c
Date: Wed, 21 May 2008 21:09:06 +0200	[thread overview]
Message-ID: <48348F72.9218.D2AA4@ceggers.gmx.de> (raw)

I think this must be swapped (result may be equal).
---
 drivers/usb/usb_ohci.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/usb_ohci.c b/drivers/usb/usb_ohci.c
index ee0f2e4..29fcbbe 100644
--- a/drivers/usb/usb_ohci.c
+++ b/drivers/usb/usb_ohci.c
@@ -1218,9 +1218,9 @@ pkt_print(NULL, dev, pipe, buffer, trans
 	}
 
 	bmRType_bReq  = cmd->requesttype | (cmd->request << 8);
-	wValue	      = cpu_to_le16 (cmd->value);
-	wIndex	      = cpu_to_le16 (cmd->index);
-	wLength	      = cpu_to_le16 (cmd->length);
+	wValue	      = le16_to_cpu (cmd->value);
+	wIndex	      = le16_to_cpu (cmd->index);
+	wLength	      = le16_to_cpu (cmd->length);
 
 	info("Root-Hub: adr: %2x cmd(%1x): %08x %04x %04x %04x",
 		dev->devnum, 8, bmRType_bReq, wValue, wIndex, wLength);
-- 
1.4.3.4

             reply	other threads:[~2008-05-21 19:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 19:09 Christian Eggers [this message]
2008-07-05 22:32 ` [U-Boot-Users] Fix endianess conversion in usb_ohci.c Wolfgang Denk
2008-07-07  7:08   ` Markus Klotzbücher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48348F72.9218.D2AA4@ceggers.gmx.de \
    --to=ceggers@gmx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox