[U-Boot-Users] [PATCH] Add support for Marvell 88E1118 phy to drivers/net/tsec.c

[U-Boot-Users] [PATCH] Add support for Marvell 88E1118 phy to drivers/net/tsec.c

[Ron Madrid]

Add support for Marvell 88E1118 phy to
drivers/net/tsec.c

Signed-off-by: Ron Madrid <ron_madrid@sbcglobal.net>

--- clean_u-boot-1.3.3/drivers/net/tsec.c	2008-05-19
03:47:11.000000000 -0700
+++ u-boot-1.3.3/drivers/net/tsec.c	2008-05-20
12:40:14.000000000 -0700
@@ -1128,6 +1128,36 @@ struct phy_info
phy_info_M88E1111S = {
 			   },
 };
 
+struct phy_info phy_info_M88E1118 = {
+	0x01410e1,
+	"Marvell 88E1118",
+	4,
+	(struct phy_cmd[]){	/* config */
+		/* Reset and configure the PHY */
+		{MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
+		{0x16, 0x0002, NULL}, /* Change Page Number */
+		{0x15, 0x1070, NULL}, /* Delay RGMII TX and RX */
+		{MIIM_GBIT_CONTROL, MIIM_GBIT_CONTROL_INIT, NULL},
+		{MIIM_ANAR, MIIM_ANAR_INIT, NULL},
+		{MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
+		{MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
+		{miim_end,}
+		},
+	(struct phy_cmd[]){	/* startup */
+		{0x16, 0x0000, NULL}, /* Change Page Number */
+		/* Status is read once to clear old link state */
+		{MIIM_STATUS, miim_read, NULL},
+		/* Auto-negotiate */
+		/* Read the status */
+		{MIIM_88E1011_PHY_STATUS, miim_read,
+		 &mii_parse_88E1011_psr},
+		{miim_end,}
+		},
+	(struct phy_cmd[]){	/* shutdown */
+		{miim_end,}
+		},
+};
+
 static unsigned int m88e1145_setmode(uint mii_reg,
struct tsec_private *priv)
 {
 	uint mii_data = read_phy_reg(priv, mii_reg);
@@ -1492,6 +1522,7 @@ struct phy_info *phy_info[] = {
 	&phy_info_BCM5464S,
 	&phy_info_M88E1011S,
 	&phy_info_M88E1111S,
+	&phy_info_M88E1118,
 	&phy_info_M88E1145,
 	&phy_info_M88E1149S,
 	&phy_info_dm9161,

[U-Boot-Users] [PATCH] Add support for Marvell 88E1118 phy to drivers/net/tsec.c

[Jean-Christophe PLAGNIOL-VILLARD]

If possible can we start to export the phy support in phy drivers to
allow other net drivers to use it.

We can start to think to implement like is done in linux to add a
generic phylib with a generir phy driver.

Best Regards,
J.

[U-Boot-Users] [PATCH] Add support for Marvell 88E1118 phy to drivers/net/tsec.c

[Ron Madrid]

That sounds like a good idea.  I was honestly kinda
surprised that this hadn't already been done (not a
critisism).  Currently though I'm trying to add
support for a new board.  I'd be glad to try and help
in the future though if this kind of implementation is
done.

Ron Madrid

--- Jean-Christophe PLAGNIOL-VILLARD
<plagnioj@jcrosoft.com> wrote:

> If possible can we start to export the phy support
> in phy drivers to
> allow other net drivers to use it.
> 
> We can start to think to implement like is done in
> linux to add a
> generic phylib with a generir phy driver.
> 
> Best Regards,
> J.
> 

[U-Boot-Users] [PATCH] Add support for Marvell 88E1118 phy to drivers/net/tsec.c

[Ben Warren]

Jean-Christophe PLAGNIOL-VILLARD wrote:
> If possible can we start to export the phy support in phy drivers to
> allow other net drivers to use it.
>
> We can start to think to implement like is done in linux to add a
> generic phylib with a generir phy driver.
>
> Best Regards,
> J.
>
>   
For now, please leave as-is and I'll pull the patch in tonight.  It's 
better to move all the PHY drivers at once than to do them piecemeal.

regards,
Ben

[U-Boot-Users] [PATCH] Add support for Marvell 88E1118 phy to drivers/net/tsec.c

[Ron Madrid]

--- Ben Warren <biggerbadderben@gmail.com> wrote:

> Jean-Christophe PLAGNIOL-VILLARD wrote:
> > If possible can we start to export the phy support
> in phy drivers to
> > allow other net drivers to use it.
> >
> > We can start to think to implement like is done in
> linux to add a
> > generic phylib with a generir phy driver.
> >
> > Best Regards,
> > J.
> >
> >   
> For now, please leave as-is and I'll pull the patch
> in tonight.  It's 

Will do,

> better to move all the PHY drivers at once than to
> do them piecemeal.

and agreed.

> 
> regards,
> Ben
> 

Ron Madrid

[U-Boot-Users] [PATCH] Add support for Marvell 88E1118 phy to drivers/net/tsec.c

[Jean-Christophe PLAGNIOL-VILLARD]

On 09:30 Thu 22 May     , Ben Warren wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
> > If possible can we start to export the phy support in phy drivers to
> > allow other net drivers to use it.
> >
> > We can start to think to implement like is done in linux to add a
> > generic phylib with a generir phy driver.
> >
> > Best Regards,
> > J.
> >
> >   
> For now, please leave as-is and I'll pull the patch in tonight.  It's 
> better to move all the PHY drivers at once than to do them piecemeal.

I agree , I just ask to start think to move to this architecture

Best Regards,
J.

[U-Boot-Users] [PATCH] Add support for Marvell 88E1118 phy to drivers/net/tsec.c

[Ben Warren]

Hi Ron,

Ron Madrid wrote:
> Add support for Marvell 88E1118 phy to
> drivers/net/tsec.c
>
> Signed-off-by: Ron Madrid <ron_madrid@sbcglobal.net>
>
> --- clean_u-boot-1.3.3/drivers/net/tsec.c	2008-05-19
> 03:47:11.000000000 -0700
> +++ u-boot-1.3.3/drivers/net/tsec.c	2008-05-20
> 12:40:14.000000000 -0700
>   
The content of this patch looks OK, but the patch itself is mangled.  
Please use git tools to create your patches, then re-submit.
> @@ -1128,6 +1128,36 @@ struct phy_info
> phy_info_M88E1111S = {
>  			   },
>  };
>  
> +struct phy_info phy_info_M88E1118 = {
> +	0x01410e1,
> +	"Marvell 88E1118",
> +	4,
> +	(struct phy_cmd[]){	/* config */
> +		/* Reset and configure the PHY */
> +		{MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
> +		{0x16, 0x0002, NULL}, /* Change Page Number */
> +		{0x15, 0x1070, NULL}, /* Delay RGMII TX and RX */
> +		{MIIM_GBIT_CONTROL, MIIM_GBIT_CONTROL_INIT, NULL},
> +		{MIIM_ANAR, MIIM_ANAR_INIT, NULL},
> +		{MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
> +		{MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
> +		{miim_end,}
> +		},
> +	(struct phy_cmd[]){	/* startup */
> +		{0x16, 0x0000, NULL}, /* Change Page Number */
> +		/* Status is read once to clear old link state */
> +		{MIIM_STATUS, miim_read, NULL},
> +		/* Auto-negotiate */
> +		/* Read the status */
> +		{MIIM_88E1011_PHY_STATUS, miim_read,
> +		 &mii_parse_88E1011_psr},
> +		{miim_end,}
> +		},
> +	(struct phy_cmd[]){	/* shutdown */
> +		{miim_end,}
> +		},
> +};
> +
>  static unsigned int m88e1145_setmode(uint mii_reg,
> struct tsec_private *priv)
>  {
>  	uint mii_data = read_phy_reg(priv, mii_reg);
> @@ -1492,6 +1522,7 @@ struct phy_info *phy_info[] = {
>  	&phy_info_BCM5464S,
>  	&phy_info_M88E1011S,
>  	&phy_info_M88E1111S,
> +	&phy_info_M88E1118,
>  	&phy_info_M88E1145,
>  	&phy_info_M88E1149S,
>  	&phy_info_dm9161,
>
>
>   
regards,
Ben