From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Loeliger Date: Fri, 23 May 2008 14:24:32 -0500 Subject: [U-Boot-Users] [PATCH 18/18] avr32: Compile atmel_mci.oconditionally In-Reply-To: References: Message-ID: <483719F0.2080601@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Ken.Fuchs at bench.com wrote: > Haavard Skinnemoen wrote: > >> Remove #ifdef CONFIG_MMC from the source file and use conditional >> compilation in the Makefile instead. > > What's wrong with the current code? Why are you doing this? > Because it is the right thing to do. :-) So that we don't gratuitously compile files that aren't even necessarily involved in the build as per configuration selections. This is all part of the longer term goal of moving to a Kconfig/Kbuild mechanism. jdl